You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/12/01 19:30:45 UTC

Re: Review Request 28362: Added new overload for Resources.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28362/#review63399
-----------------------------------------------------------



include/mesos/resources.hpp
<https://reviews.apache.org/r/28362/#comment105647>

    i think this should be explicit. The protobuf version is implicit to ease transition between protobuf and Resources so they appear to be the same type. However, a vector of Resource might be accidentally converted.


- Dominic Hamon


On Nov. 24, 2014, 11:33 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28362/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 11:33 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Needed this for my subsequent review.
> 
> Also pulled up a private method for the same reason.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 10777a62492e4a3333d764e0f75c064694e054d1 
>   src/common/resources.cpp 27c6240dd775eff3918f4771916cb9c0df94aba9 
> 
> Diff: https://reviews.apache.org/r/28362/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>