You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by gr...@apache.org on 2017/11/14 20:28:59 UTC
[incubator-superset] branch master updated: [Dashboard bug] Fix
merged filter param name (#3866)
This is an automated email from the ASF dual-hosted git repository.
graceguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/master by this push:
new 8643228 [Dashboard bug] Fix merged filter param name (#3866)
8643228 is described below
commit 8643228b51e27836a53b60b82b7c45b627665755
Author: Grace Guo <gr...@airbnb.com>
AuthorDate: Tue Nov 14 12:28:55 2017 -0800
[Dashboard bug] Fix merged filter param name (#3866)
front-end merge time filter params, and update query with param name 'extra_filters'
---
superset/assets/javascripts/dashboard/components/Dashboard.jsx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/superset/assets/javascripts/dashboard/components/Dashboard.jsx b/superset/assets/javascripts/dashboard/components/Dashboard.jsx
index 2415e36..553daf6 100644
--- a/superset/assets/javascripts/dashboard/components/Dashboard.jsx
+++ b/superset/assets/javascripts/dashboard/components/Dashboard.jsx
@@ -121,7 +121,7 @@ class Dashboard extends React.PureComponent {
getFormDataExtra(slice) {
const formDataExtra = Object.assign({}, slice.formData);
const extraFilters = this.effectiveExtraFilters(slice.slice_id);
- formDataExtra.filters = formDataExtra.filters.concat(extraFilters);
+ formDataExtra.extra_filters = formDataExtra.filters.concat(extraFilters);
return formDataExtra;
}
--
To stop receiving notification emails like this one, please contact
['"commits@superset.apache.org" <co...@superset.apache.org>'].