You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@hertzbeat.apache.org by "xuziyang (via GitHub)" <gi...@apache.org> on 2024/05/08 03:02:03 UTC
[I] [Question] why in MetricsDataController injection is a collection of stores instead of a single store instance？ [hertzbeat]
xuziyang opened a new issue, #1933:
URL: https://github.com/apache/hertzbeat/issues/1933
### Question
Since only one realtimeDataStore and one historyDataStore can be configured, why in MetricsDataController injection is a collection of stores instead of a single store instance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For additional commands, e-mail: notifications-help@hertzbeat.apache.org
Re: [I] [Question] why in MetricsDataController injection is a collection of stores instead of a single store instance？ [hertzbeat]
Posted by "tomsun28 (via GitHub)" <gi...@apache.org>.
tomsun28 commented on issue #1933:
URL: https://github.com/apache/hertzbeat/issues/1933#issuecomment-2100030043
ok👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For additional commands, e-mail: notifications-help@hertzbeat.apache.org
Re: [I] [Question] why in MetricsDataController injection is a collection of stores instead of a single store instance？ [hertzbeat]
Posted by "xuziyang (via GitHub)" <gi...@apache.org>.
xuziyang commented on issue #1933:
URL: https://github.com/apache/hertzbeat/issues/1933#issuecomment-2100015871
> Hi, this is due to historical configuration. Although we can only configure one store, many users will configure multiple ones, or forget to turn off the default one, causing the operation to fail. So here we changed to inject multiple beans and then select one.
>
> I think we can update it to inject only one instance. And we need to discuss whether we need to start reporting errors when there is no bean when startup.
from the documentation, it is possible to use only the real-time data storage and not the historical data repository.
since it's expected that no historical data repository is configured, I think it's good to give a warning at system startup if no historical data repository is configured
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For additional commands, e-mail: notifications-help@hertzbeat.apache.org
Re: [I] [Question] why in MetricsDataController injection is a collection of stores instead of a single store instance？ [hertzbeat]
Posted by "orangeCatDeveloper (via GitHub)" <gi...@apache.org>.
orangeCatDeveloper commented on issue #1933:
URL: https://github.com/apache/hertzbeat/issues/1933#issuecomment-5860509132
Resolved by #1944.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For additional commands, e-mail: notifications-help@hertzbeat.apache.org
Re: [I] [Question] why in MetricsDataController injection is a collection of stores instead of a single store instance？ [hertzbeat]
Posted by "orangeCatDeveloper (via GitHub)" <gi...@apache.org>.
orangeCatDeveloper closed issue #1933: [Question] why in MetricsDataController injection is a collection of stores instead of a single store instance？
URL: https://github.com/apache/hertzbeat/issues/1933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For additional commands, e-mail: notifications-help@hertzbeat.apache.org
Re: [I] [Question] why in MetricsDataController injection is a collection of stores instead of a single store instance？ [hertzbeat]
Posted by "tomsun28 (via GitHub)" <gi...@apache.org>.
tomsun28 commented on issue #1933:
URL: https://github.com/apache/hertzbeat/issues/1933#issuecomment-2099991705
Hi, this is due to historical configuration. Although we can only configure one store, many users will configure multiple ones, or forget to turn off the default one, causing the operation to fail. So here we changed to inject multiple beans and then select one.
I think we can update it to inject only one instance.
And we need to discuss whether we need to start reporting errors when there is no bean when startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@hertzbeat.apache.org
For additional commands, e-mail: notifications-help@hertzbeat.apache.org