[jira] [Commented] (THRIFT-5887) build/cmake/ should be prepended (not appended) to CMAKE_MODULE_PATH

["Mario Emmenlauer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-5887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18003680#comment-18003680 ] 

Mario Emmenlauer commented on THRIFT-5887:
------------------------------------------

I'm not sure that appending or prepending is a solution here. Should the files maybe be renamed, to something unique like {{DefineApacheThriftOptions.cmake}}?

> build/cmake/ should be prepended (not appended) to CMAKE_MODULE_PATH
> --------------------------------------------------------------------
>
>                 Key: THRIFT-5887
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5887
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 0.22.0
>            Reporter: Kouhei Sutou
>            Priority: Minor
>
> https://github.com/apache/thrift/blob/9cff8b9f5b217c143c75299939c32573ccd4c9c3/CMakeLists.txt#L38 appends {{build/cmake/}} to {{CMAKE_MODULE_PATH}}.
> If we build Apache Thrift by {{FetchContent}} https://cmake.org/cmake/help/latest/module/FetchContent.html, {{CMAKE_MODULE_PATH}} may have some extra paths. If these extra paths have the same file name in  https://github.com/apache/thrift/tree/master/build/cmake, our files aren't used.
> For example, both of Apache Arrow and Apache Thrift have {{DefineOptions.cmake}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)