You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2019/03/04 14:59:01 UTC
Review Request 70114: Added logging for `linux/seccomp` isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70114/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Qian Zhang.
Repository: mesos
Description
-------
Added logging for `linux/seccomp` isolator.
Diffs
-----
src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 1c94e126a0a5039e46d0e7696f4e629d41b35d50
Diff: https://reviews.apache.org/r/70114/diff/1/
Testing
-------
None: not a functional change.
Thanks,
Andrei Budnik
Re: Review Request 70114: Added logging for `linux/seccomp` isolator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70114/#review213407
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70108, 70109, 70114]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 4, 2019, 2:59 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70114/
> -----------------------------------------------------------
>
> (Updated March 4, 2019, 2:59 p.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added logging for `linux/seccomp` isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 1c94e126a0a5039e46d0e7696f4e629d41b35d50
>
>
> Diff: https://reviews.apache.org/r/70114/diff/1/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 70114: Added logging for `linux/seccomp` isolator.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70114/#review213428
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/mesos/isolators/linux/seccomp.cpp
Lines 110-111 (patched)
<https://reviews.apache.org/r/70114/#comment299367>
I would probably move it down to L126 for print the path for all seccomp profile cases.
- Gilbert Song
On March 4, 2019, 6:59 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70114/
> -----------------------------------------------------------
>
> (Updated March 4, 2019, 6:59 a.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added logging for `linux/seccomp` isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 1c94e126a0a5039e46d0e7696f4e629d41b35d50
>
>
> Diff: https://reviews.apache.org/r/70114/diff/1/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 70114: Added logging for `linux/seccomp` isolator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70114/#review213449
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70108, 70109, 70114]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 4, 2019, 3:59 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70114/
> -----------------------------------------------------------
>
> (Updated March 4, 2019, 3:59 p.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added logging for `linux/seccomp` isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 1c94e126a0a5039e46d0e7696f4e629d41b35d50
>
>
> Diff: https://reviews.apache.org/r/70114/diff/2/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 70114: Added logging for `linux/seccomp` isolator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70114/#review213435
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70108, 70109, 70114]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 4, 2019, 2:59 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70114/
> -----------------------------------------------------------
>
> (Updated March 4, 2019, 2:59 p.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added logging for `linux/seccomp` isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/linux/seccomp.cpp 1c94e126a0a5039e46d0e7696f4e629d41b35d50
>
>
> Diff: https://reviews.apache.org/r/70114/diff/2/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>