You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jordan Birdsell (Code Review)" <ge...@cloudera.org> on 2016/10/22 02:58:55 UTC
[kudu-CR] KUDU-1648 - [python] Expose Setting of Range Partitions
Jordan Birdsell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4795
Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions
......................................................................
KUDU-1648 - [python] Expose Setting of Range Partitions
Currently, the Python client does not allow developers
to set range partitions. This patch adds that capbility
and includes updates to existing tests.
Change-Id: Ib1e2c9a49196c6dd6644388d08014acd7593d4aa
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
M python/kudu/tests/util.py
5 files changed, 150 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/4795/1
--
To view, visit http://gerrit.cloudera.org:8080/4795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1e2c9a49196c6dd6644388d08014acd7593d4aa
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
[kudu-CR] KUDU-1648 - [python] Expose Setting of Range Partitions
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4795
to look at the new patch set (#5).
Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions
......................................................................
KUDU-1648 - [python] Expose Setting of Range Partitions
Currently, the Python client does not allow developers
to set range partitions. This patch adds that capability
and includes updates to existing tests.
Change-Id: Ib1e2c9a49196c6dd6644388d08014acd7593d4aa
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
M python/kudu/tests/util.py
5 files changed, 174 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/4795/5
--
To view, visit http://gerrit.cloudera.org:8080/4795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib1e2c9a49196c6dd6644388d08014acd7593d4aa
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-1648 - [python] Expose Setting of Range Partitions
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions
......................................................................
KUDU-1648 - [python] Expose Setting of Range Partitions
Currently, the Python client does not allow developers
to set range partitions. This patch adds that capability
and includes updates to existing tests.
Change-Id: Ib1e2c9a49196c6dd6644388d08014acd7593d4aa
Reviewed-on: http://gerrit.cloudera.org:8080/4795
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
M python/kudu/tests/util.py
5 files changed, 174 insertions(+), 11 deletions(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1e2c9a49196c6dd6644388d08014acd7593d4aa
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-1648 - [python] Expose Setting of Range Partitions
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4795
to look at the new patch set (#2).
Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions
......................................................................
KUDU-1648 - [python] Expose Setting of Range Partitions
Currently, the Python client does not allow developers
to set range partitions. This patch adds that capbility
and includes updates to existing tests.
Change-Id: Ib1e2c9a49196c6dd6644388d08014acd7593d4aa
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
M python/kudu/tests/util.py
5 files changed, 150 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/4795/2
--
To view, visit http://gerrit.cloudera.org:8080/4795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib1e2c9a49196c6dd6644388d08014acd7593d4aa
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-1648 - [python] Expose Setting of Range Partitions
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4795/2//COMMIT_MSG
Commit Message:
PS2, Line 10: capabilit
> nit: sp
Done
http://gerrit.cloudera.org:8080/#/c/4795/2/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:
PS2, Line 136: {'key': 10}
> I'm wondering what happens if one sets invalid column names or wrongly type
The PartialRow usability patch just abstracted the old op[key] = value approach. That being said, that API had no tests :). I've added a test case to account for this. Thanks for calling this out, I found an uncaught exception that was causing SIGSEGVs.
--
To view, visit http://gerrit.cloudera.org:8080/4795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1e2c9a49196c6dd6644388d08014acd7593d4aa
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1648 - [python] Expose Setting of Range Partitions
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/4795/2//COMMIT_MSG
Commit Message:
PS2, Line 10: capbility
nit: sp
http://gerrit.cloudera.org:8080/#/c/4795/2/python/kudu/tests/test_client.py
File python/kudu/tests/test_client.py:
PS2, Line 136: {'key': 10}
I'm wondering what happens if one sets invalid column names or wrongly typed values in the splits or bounds, and also more generally in PartialRows constructed from list/tuple/dict. Here, it would catch it when create_table is executed if the bounds or splits are specified as list/tuple/dict, right? Are there any tests for what happens in these kinds of cases? This comment might belong in the PartialRow usability patch...
--
To view, visit http://gerrit.cloudera.org:8080/4795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1e2c9a49196c6dd6644388d08014acd7593d4aa
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1648 - [python] Expose Setting of Range Partitions
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4795
to look at the new patch set (#4).
Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions
......................................................................
KUDU-1648 - [python] Expose Setting of Range Partitions
Currently, the Python client does not allow developers
to set range partitions. This patch adds that capability
and includes updates to existing tests.
Change-Id: Ib1e2c9a49196c6dd6644388d08014acd7593d4aa
---
M python/kudu/__init__.py
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
M python/kudu/tests/util.py
5 files changed, 174 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/4795/4
--
To view, visit http://gerrit.cloudera.org:8080/4795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib1e2c9a49196c6dd6644388d08014acd7593d4aa
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-1648 - [python] Expose Setting of Range Partitions
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1e2c9a49196c6dd6644388d08014acd7593d4aa
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No