You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Simon Lessard (JIRA)" <ad...@incubator.apache.org> on 2006/07/06 13:16:30 UTC

[jira] Created: (ADFFACES-46) Client side validation message does not escape the ' character

Client side validation message does not escape the ' character
--------------------------------------------------------------

         Key: ADFFACES-46
         URL: http://issues.apache.org/jira/browse/ADFFACES-46
     Project: MyFaces ADF-Faces
        Type: Bug

    Reporter: Simon Lessard


Copied from http://forums.oracle.com/forums/thread.jspa?messageID=1223575&#1223575


Here's a small bug with validation message when client-side validation is enabled. If the error message (or field label) contain the character ', ADF Faces won't escape it and will thus break the printing with some nasty characters. A really poor workaround is to set the messages with the ' escaped, but then it will fail when it's the label that contains it or when you disable client-side validation (then the printed message in the page will contains both of the apostrophes).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (ADFFACES-46) Client side validation message does not escape the ' character

Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/ADFFACES-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthias Weßendorf updated ADFFACES-46:
---------------------------------------

        Fix Version/s: 1.0.0-incubating-core
    Affects Version/s: 1.0.0-incubating-core

> Client side validation message does not escape the ' character
> --------------------------------------------------------------
>
>                 Key: ADFFACES-46
>                 URL: https://issues.apache.org/jira/browse/ADFFACES-46
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>    Affects Versions: 1.0.0-incubating-core
>            Reporter: Simon Lessard
>         Assigned To: Adam Winer
>             Fix For: 1.0.0-incubating-core
>
>
> Copied from http://forums.oracle.com/forums/thread.jspa?messageID=1223575&#1223575
> Here's a small bug with validation message when client-side validation is enabled. If the error message (or field label) contain the character ', ADF Faces won't escape it and will thus break the printing with some nasty characters. A really poor workaround is to set the messages with the ' escaped, but then it will fail when it's the label that contains it or when you disable client-side validation (then the printed message in the page will contains both of the apostrophes).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ADFFACES-46) Client side validation message does not escape the ' character

Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
    [ http://issues.apache.org/jira/browse/ADFFACES-46?page=comments#action_12419779 ] 

Simon Lessard commented on ADFFACES-46:
---------------------------------------

This issue is not a Java bug, it's a resource bundle one. It occurs because FastMessageFormat use single quotes as an escape character, requiring 2 consecutive single quotes to print one. 

So the requiredMessageDetail need to follow that rule as well.

As for the resource bundle bug, all of them will have to be checked to make sure they use two consecutive single quotes which is not the case currently. For example, with French locale, the following messages does not get rendered properly:

"La valeur "{0}" n'est pas un nombre." is transformed into "La valeur "{0}" nest pas un nombre."

The same thing happens with selectInputDate's French messages. 

TODO: Maybe document the requiredMessageDetail attribute's description in the .tld and .xml in order to specify the single quote issue and maybe also in general documentation about message bundle?

> Client side validation message does not escape the ' character
> --------------------------------------------------------------
>
>          Key: ADFFACES-46
>          URL: http://issues.apache.org/jira/browse/ADFFACES-46
>      Project: MyFaces ADF-Faces
>         Type: Bug

>     Reporter: Simon Lessard

>
> Copied from http://forums.oracle.com/forums/thread.jspa?messageID=1223575&#1223575
> Here's a small bug with validation message when client-side validation is enabled. If the error message (or field label) contain the character ', ADF Faces won't escape it and will thus break the printing with some nasty characters. A really poor workaround is to set the messages with the ' escaped, but then it will fail when it's the label that contains it or when you disable client-side validation (then the printed message in the page will contains both of the apostrophes).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (ADFFACES-46) Client side validation message does not escape the ' character

Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
    [ http://issues.apache.org/jira/browse/ADFFACES-46?page=comments#action_12419803 ] 

Adam Winer commented on ADFFACES-46:
------------------------------------

Could you retest with the latest source?  (At least SVN revision 420024).  At least some of the symptoms you see here should have been fixed.

> Client side validation message does not escape the ' character
> --------------------------------------------------------------
>
>          Key: ADFFACES-46
>          URL: http://issues.apache.org/jira/browse/ADFFACES-46
>      Project: MyFaces ADF-Faces
>         Type: Bug

>     Reporter: Simon Lessard

>
> Copied from http://forums.oracle.com/forums/thread.jspa?messageID=1223575&#1223575
> Here's a small bug with validation message when client-side validation is enabled. If the error message (or field label) contain the character ', ADF Faces won't escape it and will thus break the printing with some nasty characters. A really poor workaround is to set the messages with the ' escaped, but then it will fail when it's the label that contains it or when you disable client-side validation (then the printed message in the page will contains both of the apostrophes).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (ADFFACES-46) Client side validation message does not escape the ' character

Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-46?page=all ]
     
Adam Winer resolved ADFFACES-46:
--------------------------------

    Resolution: Fixed

Thanks for confirming the fix.

> Client side validation message does not escape the ' character
> --------------------------------------------------------------
>
>          Key: ADFFACES-46
>          URL: http://issues.apache.org/jira/browse/ADFFACES-46
>      Project: MyFaces ADF-Faces
>         Type: Bug

>     Reporter: Simon Lessard
>     Assignee: Adam Winer

>
> Copied from http://forums.oracle.com/forums/thread.jspa?messageID=1223575&#1223575
> Here's a small bug with validation message when client-side validation is enabled. If the error message (or field label) contain the character ', ADF Faces won't escape it and will thus break the printing with some nasty characters. A really poor workaround is to set the messages with the ' escaped, but then it will fail when it's the label that contains it or when you disable client-side validation (then the printed message in the page will contains both of the apostrophes).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (ADFFACES-46) Client side validation message does not escape the ' character

Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
    [ http://issues.apache.org/jira/browse/ADFFACES-46?page=comments#action_12420071 ] 

Simon Lessard commented on ADFFACES-46:
---------------------------------------

Retested with revision 420024. The bug no longer occurs with the specified test case.

> Client side validation message does not escape the ' character
> --------------------------------------------------------------
>
>          Key: ADFFACES-46
>          URL: http://issues.apache.org/jira/browse/ADFFACES-46
>      Project: MyFaces ADF-Faces
>         Type: Bug

>     Reporter: Simon Lessard

>
> Copied from http://forums.oracle.com/forums/thread.jspa?messageID=1223575&#1223575
> Here's a small bug with validation message when client-side validation is enabled. If the error message (or field label) contain the character ', ADF Faces won't escape it and will thus break the printing with some nasty characters. A really poor workaround is to set the messages with the ' escaped, but then it will fail when it's the label that contains it or when you disable client-side validation (then the printed message in the page will contains both of the apostrophes).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (ADFFACES-46) Client side validation message does not escape the ' character

Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/ADFFACES-46?page=all ]

Adam Winer reassigned ADFFACES-46:
----------------------------------

    Assign To: Adam Winer

> Client side validation message does not escape the ' character
> --------------------------------------------------------------
>
>          Key: ADFFACES-46
>          URL: http://issues.apache.org/jira/browse/ADFFACES-46
>      Project: MyFaces ADF-Faces
>         Type: Bug

>     Reporter: Simon Lessard
>     Assignee: Adam Winer

>
> Copied from http://forums.oracle.com/forums/thread.jspa?messageID=1223575&#1223575
> Here's a small bug with validation message when client-side validation is enabled. If the error message (or field label) contain the character ', ADF Faces won't escape it and will thus break the printing with some nasty characters. A really poor workaround is to set the messages with the ' escaped, but then it will fail when it's the label that contains it or when you disable client-side validation (then the printed message in the page will contains both of the apostrophes).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira