You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by jp...@apache.org on 2018/12/05 01:50:40 UTC

[mesos] 04/04: Improved the code comments for `getContainerDevicesPath`.

This is an automated email from the ASF dual-hosted git repository.

jpeach pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git

commit dad74012fa02a7fbf61b09968d9b7e9c730b1c97
Author: James Peach <jp...@apache.org>
AuthorDate: Tue Dec 4 13:57:31 2018 -0800

    Improved the code comments for `getContainerDevicesPath`.
    
    Review: https://reviews.apache.org/r/69211/
---
 src/slave/containerizer/mesos/paths.hpp | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/slave/containerizer/mesos/paths.hpp b/src/slave/containerizer/mesos/paths.hpp
index de3981d..2dc222e 100644
--- a/src/slave/containerizer/mesos/paths.hpp
+++ b/src/slave/containerizer/mesos/paths.hpp
@@ -54,6 +54,7 @@ namespace paths {
 //           |   |   |-- <more nesting of containers>
 //           |   |-- pid
 //           |   |-- ...
+//           |-- devices
 //           |-- force_destroy_on_recovery
 //           |-- io_switchboard
 //           |   |-- pid
@@ -108,8 +109,11 @@ std::string getRuntimePath(
     const ContainerID& containerId);
 
 
-// Given a `runtimeDir`, construct a unique directory to store
-// per-container device nodes.
+// Given a `runtimeDir`, construct a unique directory to stage
+// per-container device nodes. This directory is initially created
+// and  populated by the `filesystem/linux` isolator. Any subsequent
+// isolators may add devices to this directory and bind mount them
+// into the container.
 std::string getContainerDevicesPath(
     const std::string& runtimeDir,
     const ContainerID& containerId);