You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kumarUjjawal (via GitHub)" <gi...@apache.org> on 2026/04/10 06:35:40 UTC
[PR] feat(parquet): add StatisticsConverter::from_column_index [arrow-rs]
kumarUjjawal opened a new pull request, #9687:
URL: https://github.com/apache/arrow-rs/pull/9687
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
-->
- Closes #9539.
# Rationale for this change
`StatisticsConverter::try_new` resolves columns through `parquet_column()`, which only supports top-level non-nested columns. Because of that, callers that already know the Parquet leaf index for a nested field cannot use `StatisticsConverter` to read statistics for that field.
This blocks reading stats for fields inside structs.
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
- add `StatisticsConverter::from_column_index(...)`
- keep `StatisticsConverter::try_new(...)` behavior unchanged
- update docs to explain when to use each constructor
- add a test that writes a struct column and reads statistics for each child
field through the new API
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
Yes
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
Yes.
This adds a new public constructor: `StatisticsConverter::from_column_index(...)`
There are no breaking changes.
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(parquet): add StatisticsConverter::from_column_index [arrow-rs]
Posted by "friendlymatthew (via GitHub)" <gi...@apache.org>.
friendlymatthew commented on PR #9687:
URL: https://github.com/apache/arrow-rs/pull/9687#issuecomment-4766176110
> @adriangb since the other pr doesn't have any activity should we move forward with this?
It seems like this PR is pretty identical with my PR. I am curious to hear about your use case for this API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(parquet): add StatisticsConverter::from_column_index [arrow-rs]
Posted by "kumarUjjawal (via GitHub)" <gi...@apache.org>.
kumarUjjawal commented on PR #9687:
URL: https://github.com/apache/arrow-rs/pull/9687#issuecomment-4227977068
I have reached out to @friendlymatthew for this, I will get back to you once we decide how to proceed forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(parquet): add StatisticsConverter::from_column_index [arrow-rs]
Posted by "sdf-jkl (via GitHub)" <gi...@apache.org>.
sdf-jkl commented on PR #9687:
URL: https://github.com/apache/arrow-rs/pull/9687#issuecomment-4764277040
Hi @kumarUjjawal @friendlymatthew this looks complete to me. Are you looking to push it forward?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(parquet): add StatisticsConverter::from_column_index [arrow-rs]
Posted by "kumarUjjawal (via GitHub)" <gi...@apache.org>.
kumarUjjawal commented on PR #9687:
URL: https://github.com/apache/arrow-rs/pull/9687#issuecomment-4766201134
> > @adriangb since the other pr doesn't have any activity should we move forward with this?
>
>
>
> It seems like this PR is pretty identical with my PR. I am curious to hear about your use case for this API
https://github.com/apache/datafusion/issues/8334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(parquet): add StatisticsConverter::from_column_index [arrow-rs]
Posted by "friendlymatthew (via GitHub)" <gi...@apache.org>.
friendlymatthew commented on PR #9687:
URL: https://github.com/apache/arrow-rs/pull/9687#issuecomment-4766241638
> If you can move forward with your pr that would also be acceptable and I can close this.
Sounds good. Fwiw, I think my PR is ready for merge, it's merely marked as a draft as my use case was related to some change in Datafusion.
I'll flip the PR back to Ready and tag you in it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(parquet): add StatisticsConverter::from_column_index [arrow-rs]
Posted by "friendlymatthew (via GitHub)" <gi...@apache.org>.
friendlymatthew commented on PR #9687:
URL: https://github.com/apache/arrow-rs/pull/9687#issuecomment-4259956745
Hi I've been under the weather but I will respond shortly. Happy to collaborate on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(parquet): add StatisticsConverter::from_column_index [arrow-rs]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on PR #9687:
URL: https://github.com/apache/arrow-rs/pull/9687#issuecomment-4223782661
I think @friendlymatthew is also working on this, maybe you can coordinate efforts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(parquet): add StatisticsConverter::from_column_index [arrow-rs]
Posted by "friendlymatthew (via GitHub)" <gi...@apache.org>.
friendlymatthew commented on PR #9687:
URL: https://github.com/apache/arrow-rs/pull/9687#issuecomment-4259954421
Hi I have been under the weather this week but I will respond shortly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(parquet): add StatisticsConverter::from_column_index [arrow-rs]
Posted by "kumarUjjawal (via GitHub)" <gi...@apache.org>.
kumarUjjawal commented on PR #9687:
URL: https://github.com/apache/arrow-rs/pull/9687#issuecomment-4766261120
> I think my PR is ready for merge,
Great 🫡
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(parquet): add StatisticsConverter::from_column_index [arrow-rs]
Posted by "kumarUjjawal (via GitHub)" <gi...@apache.org>.
kumarUjjawal commented on PR #9687:
URL: https://github.com/apache/arrow-rs/pull/9687#issuecomment-4261852961
> Hi I've been under the weather but I will respond shortly. Happy to collaborate on this
Hi, no worries take your time. I can wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(parquet): add StatisticsConverter::from_column_index [arrow-rs]
Posted by "kumarUjjawal (via GitHub)" <gi...@apache.org>.
kumarUjjawal commented on PR #9687:
URL: https://github.com/apache/arrow-rs/pull/9687#issuecomment-4764570689
@adriangb since the other pr doesn't have any activity should we move forward with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(parquet): add StatisticsConverter::from_column_index [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #9687:
URL: https://github.com/apache/arrow-rs/pull/9687#issuecomment-4225681053
There is this one from @friendlymatthew
- https://github.com/apache/arrow-rs/pull/9540
it would be super helpful to combine efforts (e.g. by reviewing the PRs together) and pinging me when you think they are ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(parquet): add StatisticsConverter::from_column_index [arrow-rs]
Posted by "friendlymatthew (via GitHub)" <gi...@apache.org>.
friendlymatthew commented on PR #9687:
URL: https://github.com/apache/arrow-rs/pull/9687#issuecomment-4259960392
@kumarUjjawal is there a specific use case that you are solving?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(parquet): add StatisticsConverter::from_column_index [arrow-rs]
Posted by "kumarUjjawal (via GitHub)" <gi...@apache.org>.
kumarUjjawal commented on PR #9687:
URL: https://github.com/apache/arrow-rs/pull/9687#issuecomment-4766208220
> > @adriangb since the other pr doesn't have any activity should we move forward with this?
>
>
>
> It seems like this PR is pretty identical with my PR. I am curious to hear about your use case for this API
If you can move forward with your pr that would also be acceptable and I can close this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(parquet): add StatisticsConverter::from_column_index [arrow-rs]
Posted by "kumarUjjawal (via GitHub)" <gi...@apache.org>.
kumarUjjawal closed pull request #9687: feat(parquet): add StatisticsConverter::from_column_index
URL: https://github.com/apache/arrow-rs/pull/9687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org