[jira] [Commented] (OFBIZ-7010) Shipping method is shown on all Promo Conditions even when only a single condition includes Shipping Method

["Mridul Pathak (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244230#comment-15244230 ] 

Mridul Pathak commented on OFBIZ-7010:
--------------------------------------

Thanks Swapnil for reporting the issue and providing the patch. Your fix has been committed in,
* Trunk r1739447.
* 15.12 r1739453.
* 14.12 r1739455.
* 13.07 r1739458.
* 12.04 r1739461.

> Shipping method is shown on all Promo Conditions even when only a single condition includes Shipping Method
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-7010
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7010
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, Release Branch 15.12
>            Reporter: Swapnil M Mane
>            Assignee: Mridul Pathak
>            Priority: Minor
>         Attachments: OFBIZ-7010-For1307.patch, OFBIZ-7010.patch
>
>
> If we create any Promo condition by selecting any Shipping Method.
> Now for all the conditions, we create after this, automatically includes the previously selected Shipping Method.
> ___________________________________________________________
> Reason:
> Basically, it's a UI issue, the Promo Condition created in the database are correct.
> In EditProductPromoRules.ftl, we assign 'carrierShippingMethod' and 'carrierParty' in iteration with the Promotion condition 'productPromoConds'
> {{code}}
> <#list productPromoConds as productPromoCond>
> ...
>    <#assign carrierShippingMethod = productPromoCond.otherValue!>
> ...
> {{code}}
> ___________________________________________________________
> Solution:
> Before assigning the 'carrierShippingMethod' and 'carrierParty' from Promo Condition, reset the previously set value.
> for e.g.
> <#assign carrierShippingMethod = ""/>
> <#if otherValue?has_content && otherValue.contains("@")>
>   <#assign carrierShippingMethod = productPromoCond.otherValue!>
> </#if>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)