You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by chermenin <gi...@git.apache.org> on 2016/12/05 09:51:10 UTC
[GitHub] flink pull request #2937: [FLINK-4303] Examples for CEP library.
GitHub user chermenin opened a pull request:
https://github.com/apache/flink/pull/2937
[FLINK-4303] Examples for CEP library.
Added example programs written in Java and Scala. They based on @tillrohrmann 's monitoring example.
This issue will be closed by this PR: https://issues.apache.org/jira/browse/FLINK-4303.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chermenin/flink flink-4303
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2937.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2937
----
commit a051a55d8b9022c1fa1c71194fc17f43224c9b21
Author: Aleksandr Chermenin <al...@epam.com>
Date: 2016-12-05T09:44:39Z
[FLINK-4303] Added examples for CEP library.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2937: [FLINK-4303] [cep] Examples for CEP library.
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2937
Hi @DmytroShkvyra ! Great to hear that you want to contribute to Flink!
To see the features that are pending, I would suggest to have a look at the JIRAs that have CEP as component.
A good JIRA to start from, is the one from this PR (https://issues.apache.org/jira/browse/FLINK-4303). Adding examples will help you get familiarized with the new features and with the library in general.
Unfortunately the documentation is not up-to-date but I am working on it and I will merge it next week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2937: [FLINK-4303] [cep] Examples for CEP library.
Posted by AndrewZh <gi...@git.apache.org>.
Github user AndrewZh commented on the issue:
https://github.com/apache/flink/pull/2937
Hi @kl0u
I will continue the work started by Dmytro.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2937: [FLINK-4303] [cep] Examples for CEP library.
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2937#discussion_r97481738
--- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/examples/events/MonitoringEvent.scala ---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.cep.scala.examples.events
+
+class MonitoringEvent(rackID: Int) {
--- End diff --
Same here: Class-level Javadocs will be nice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2937: [FLINK-4303] [cep] Examples for CEP library.
Posted by chermenin <gi...@git.apache.org>.
Github user chermenin commented on the issue:
https://github.com/apache/flink/pull/2937
Thanks for your comment, but I'm afraid I don't have enough time to work on this task now. I'll just close this PR for now. It possible I'll come back to the task in the future if it will be needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2937: [FLINK-4303] [cep] Examples for CEP library.
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2937#discussion_r97481654
--- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/examples/CEPMonitoringExample.scala ---
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.cep.scala.examples
+
+import org.apache.flink.cep.scala.CEP
+import org.apache.flink.cep.scala.examples.events.{MonitoringEvent, TemperatureAlert, TemperatureEvent, TemperatureWarning}
+import org.apache.flink.cep.scala.examples.sources.MonitoringEventSource
+import org.apache.flink.cep.scala.pattern.Pattern
+import org.apache.flink.streaming.api.TimeCharacteristic
+import org.apache.flink.streaming.api.functions.IngestionTimeExtractor
+import org.apache.flink.streaming.api.scala.{DataStream, StreamExecutionEnvironment, createTypeInformation}
+import org.apache.flink.streaming.api.windowing.time.Time
+
+object CEPMonitoringExample {
--- End diff --
It would be great if there's Javadoc explaining what the example demonstrates exactly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2937: [FLINK-4303] [cep] Examples for CEP library.
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2937
Thanks a lot @chermenin ! The same comment also holds for the branching patterns PR. The PR is outdated but the issue is still valid. So if you ever want to work on that, let us know!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2937: [FLINK-4303] [cep] Examples for CEP library.
Posted by DmytroShkvyra <gi...@git.apache.org>.
Github user DmytroShkvyra commented on the issue:
https://github.com/apache/flink/pull/2937
Hi @kl0u !
I'm continue work on @chermenin 's PR. I'm new in CEP.
> And sorry for the really late reply. As you may have noticed the CEP library has been significantly enriched for the 1.3 version with a bunch of cool new features (and there are a lot more in the pipeline).
Could you give me a hint which features should be implemented in the pipline?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2937: [FLINK-4303] [cep] Examples for CEP library.
Posted by chermenin <gi...@git.apache.org>.
Github user chermenin closed the pull request at:
https://github.com/apache/flink/pull/2937
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2937: [FLINK-4303] [cep] Examples for CEP library.
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2937
Hi @chermenin .
And sorry for the really late reply. As you may have noticed the CEP library has been significantly enriched for the 1.3 version with a bunch of cool new features (and there are a lot more in the pipeline).
Given this, this PR is a bit outdated, but the task of having some examples illustrating the new capabilities of the library remain. Would you still like to work on that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---