You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/06/30 16:53:18 UTC
[GitHub] [solr-operator] HoustonPutman opened a new pull request, #451: Ability to customize default initContainer resources
HoustonPutman opened a new pull request, #451:
URL: https://github.com/apache/solr-operator/pull/451
Resolves #448
The new SolrCloud option is `Spec.customSolrKubeOptions.podOptions.defaultInitContainerResources`.
The option can also be enabled in the Solr Helm chart through: `podOptions.defaultInitContainerResources`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] HoustonPutman merged pull request #451: Ability to customize default initContainer resources
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged PR #451:
URL: https://github.com/apache/solr-operator/pull/451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] gerlowskija commented on a diff in pull request #451: Ability to customize default initContainer resources
Posted by GitBox <gi...@apache.org>.
gerlowskija commented on code in PR #451:
URL: https://github.com/apache/solr-operator/pull/451#discussion_r915742992
##########
api/v1beta1/common_types.go:
##########
@@ -150,6 +149,10 @@ type PodOptions struct {
// +listMapKey=whenUnsatisfiable
// +optional
TopologySpreadConstraints []corev1.TopologySpreadConstraint `json:"topologySpreadConstraints,omitempty"`
+
+ // ProvidedInitContainerResources is the resource requirements for the default init container(s) created by the Solr Operator if any are created.
Review Comment:
[0] Looks like this comment is out of sync with the new field-name you ultimately went with here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr-operator] huijieliu commented on a diff in pull request #451: Ability to customize default initContainer resources
Posted by GitBox <gi...@apache.org>.
huijieliu commented on code in PR #451:
URL: https://github.com/apache/solr-operator/pull/451#discussion_r915294179
##########
controllers/util/solr_util.go:
##########
@@ -607,12 +615,20 @@ func generateSolrSetupInitContainers(solrCloud *solr.SolrCloud, solrCloudStatus
}
}
+ volumePrepResources := corev1.ResourceList{
+ corev1.ResourceCPU: *DefaultSolrVolumePrepInitContainerCPU,
Review Comment:
👏This will help to make sure if we configure our solr resources with limit=request as well, the pod will get assigned with QoS class Guaranteed
##########
helm/solr/templates/_custom_option_helpers.tpl:
##########
@@ -98,6 +98,10 @@ initContainers:
topologySpreadConstraints:
{{- toYaml .Values.podOptions.topologySpreadConstraints | nindent 2 }}
{{ end }}
+{{- if .Values.podOptions.defaultInitContainerResources -}}
+defaultInitContainerResources:
Review Comment:
discussed offline, using default resource to configure both init container resource should be good for now if we need to custom init container resources as both are light weight init containers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org