You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "horizonzy (via GitHub)" <gi...@apache.org> on 2023/07/30 11:41:29 UTC
[GitHub] [bookkeeper] horizonzy opened a new pull request, #4041: Make compatible between DefaultEntryLogger and DirectEntryLogger
horizonzy opened a new pull request, #4041:
URL: https://github.com/apache/bookkeeper/pull/4041
Descriptions of the changes in this PR:
Fixes #4040
Upgrade guide:
If the user already uses the DirectEntryLogger in production, can not disable DirectEntryLogger directly.
There are two ways:
1. Upgrade to the version with this PR, and disable DirectEntryLogger. Then restart, and the data won't be lost.
2. If you don't want to upgrade to the bookie version, you should stop the bookie first, then find the entry log which has the biggest log id. Modify the `lastLogId` file content using the biggest log id. (Not recommend)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy closed pull request #4041: Make compatible between DefaultEntryLogger and DirectEntryLogger
Posted by "horizonzy (via GitHub)" <gi...@apache.org>.
horizonzy closed pull request #4041: Make compatible between DefaultEntryLogger and DirectEntryLogger
URL: https://github.com/apache/bookkeeper/pull/4041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap commented on a diff in pull request #4041: Make compatible between DefaultEntryLogger and DirectEntryLogger
Posted by "zymap (via GitHub)" <gi...@apache.org>.
zymap commented on code in PR #4041:
URL: https://github.com/apache/bookkeeper/pull/4041#discussion_r1289441766
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/DefaultEntryLogger.java:
##########
@@ -557,6 +568,17 @@ private long getLastLogId(File dir) {
return logs.get(logs.size() - 1);
}
+ private long getLastLogIdInDir(File dir) {
Review Comment:
Don't we need to consider the gap? Like how it implemented in the EntryLogIdsImpl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on pull request #4041: Make compatible between DefaultEntryLogger and DirectEntryLogger
Posted by "horizonzy (via GitHub)" <gi...@apache.org>.
horizonzy commented on PR #4041:
URL: https://github.com/apache/bookkeeper/pull/4041#issuecomment-1660294335
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap merged pull request #4041: Make compatible between DefaultEntryLogger and DirectEntryLogger
Posted by "zymap (via GitHub)" <gi...@apache.org>.
zymap merged PR #4041:
URL: https://github.com/apache/bookkeeper/pull/4041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org