You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/22 13:30:03 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new issue #1818: feat: support more judgment conditions for plugin orchestration
nic-chen opened a new issue #1818:
URL: https://github.com/apache/apisix-dashboard/issues/1818
# Feature request
## Please describe your feature
Currently, only judgment by code is supported for plugin orchestration.
No other conditions were used and tested.
We could add support for more judgment conditions, such as ctx attributes, vars, etc.
## Describe the solution you'd like
Add test case for more judgment conditions, such as ctx attributes, vars, etc.
If necessary, we also need to update the dependent library [dag-to-lua](https://github.com/api7/dag-to-lua)
The FE also needs to be modified accordingly.
Related issue:
https://github.com/api7/dag-to-lua/issues/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1818: feat: support more judgment conditions for plugin orchestration
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1818:
URL: https://github.com/apache/apisix-dashboard/issues/1818#issuecomment-842776628
> Written in the description:
>
> Add test case for more judgment conditions, such as ctx attributes, vars, etc.
>
> If necessary, we also need to update the dependent library dag-to-lua
>
> here is an example:
> https://github.com/apache/apisix-dashboard/blob/master/api/test/testdata/dag-conf.json#L17
>
> We can try to change the condition to: `ctx.route_id == 1` or some other vars
Assign to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1818: feat: support more judgment conditions for plugin orchestration
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1818:
URL: https://github.com/apache/apisix-dashboard/issues/1818#issuecomment-825684952
😳 Could you explain more detailed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1818: feat: support more judgment conditions for plugin orchestration
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1818:
URL: https://github.com/apache/apisix-dashboard/issues/1818#issuecomment-825352103
What do you mean?
Only add testcase for plugin orchestration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1818: feat: support more judgment conditions for plugin orchestration
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1818:
URL: https://github.com/apache/apisix-dashboard/issues/1818#issuecomment-841796507
ping @nic-chen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1818: feat: support more judgment conditions for plugin orchestration
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1818:
URL: https://github.com/apache/apisix-dashboard/issues/1818#issuecomment-843029521
> Assign to you?
Sure. If no one deals with this issue, I will handle it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1818: feat: support more judgment conditions for plugin orchestration
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1818:
URL: https://github.com/apache/apisix-dashboard/issues/1818#issuecomment-842765228
Written in the description:
Add test case for more judgment conditions, such as ctx attributes, vars, etc.
If necessary, we also need to update the dependent library dag-to-lua
here is an example:
https://github.com/apache/apisix-dashboard/blob/master/api/test/testdata/dag-conf.json#L17
We can try to change the condition to: `ctx.route_id == 1` or some other vars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1818: feat: support more judgment conditions for plugin orchestration
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1818:
URL: https://github.com/apache/apisix-dashboard/issues/1818#issuecomment-841796507
ping @nic-chen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org