[jira] [Commented] (CB-10660) uninstalling a plugin with tag failed

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156321#comment-15156321 ] 

ASF GitHub Bot commented on CB-10660:
-------------------------------------

GitHub user bso-intel opened a pull request:

    https://github.com/apache/cordova-android/pull/261

    CB-10660 fixed the exception when removing a non-existing directory

    It is ALWAYS safer to check if the directory exists before it tires to remove the directory.
    The uninstallation of the plugin with a <framework> tag failed because of this issue.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bso-intel/cordova-android CB-10660

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #261
    
----
commit 8604829854b59f14938796c109e446c36de9720f
Author: Byoungro So <by...@intel.com>
Date:   2016-02-22T00:25:21Z

    CB-10660 fixed the exception when removing a non-existing directory

----


> uninstalling a plugin with <framework> tag failed
> -------------------------------------------------
>
>                 Key: CB-10660
>                 URL: https://issues.apache.org/jira/browse/CB-10660
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>            Reporter: Byoungro So
>            Assignee: Byoungro So
>
> In the Intel XDK environment, we install the plugin in a separate area than the <project_root>/platforms/<platform> directory.
> So, the src directory relative to the <project_root> directory may not exist.
> Cordova-android's plugin handler removes the parent directory if the last framework subdirectory is removed.
> This is done without checking the existence of the parent directory.
> This causes the uninstallation of certain plugins to fail.
> It is always safer to check the existence of the directory before it tries to remove the directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org