[GitHub] [incubator-seatunnel] kezhenxu94 commented on a change in pull request #1210: [Feature] [ci] Automatically generate LICENSE

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #1210:
URL: https://github.com/apache/incubator-seatunnel/pull/1210#discussion_r817362175



##########
File path: pom.xml
##########
@@ -789,6 +790,51 @@
                     <artifactId>build-helper-maven-plugin</artifactId>
                     <version>${maven-helper-plugin.version}</version>
                 </plugin>
+
+                <plugin>
+                    <groupId>org.codehaus.mojo</groupId>
+                    <artifactId>license-maven-plugin</artifactId>
+                    <version>${maven-license-maven-plugin}</version>
+                    <executions>
+                        <execution>
+                            <id>download</id>
+                            <goals>
+                                <goal>download-licenses</goal>
+                            </goals>
+                        </execution>
+                    </executions>
+                    <configuration>
+                        <outputDirectory>${project.basedir}/seatunnel-dist/target/</outputDirectory>
+                        <thirdPartyFilename>THIRD-PARTY.txt</thirdPartyFilename>
+                        <sortArtifactByName>true</sortArtifactByName>
+                        <useMissingFile>false</useMissingFile>
+                        <addJavaLicenseAfterPackage>true</addJavaLicenseAfterPackage>
+                    </configuration>
+                </plugin>
+
+                <plugin>
+                    <groupId>org.codehaus.mojo</groupId>
+                    <artifactId>exec-maven-plugin</artifactId>
+                    <version>${exec-maven-plugin.version}</version>
+                    <executions>
+                        <execution>
+                            <id>license</id>
+                            <phase>package</phase>
+                            <goals>
+                                <goal>exec</goal>
+                            </goals>
+                            <configuration>

Review comment:
       @asdf2014 Can you add a dedicated property to control this goal, using `-Dmaven-exec-skip=false/true` results in either none or all goals are executed, you can see an example in `tools/dependencies/checkLicense.sh` where we want to execute `exec` plugin but we don't need to execute this goal (copy license file)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org