[GitHub] [mynewt-core] sjanc commented on a change in pull request #2614: nrf5340: Conditional Rev A errata 26 fix

[GitBox <gi...@apache.org>]

sjanc commented on a change in pull request #2614:
URL: https://github.com/apache/mynewt-core/pull/2614#discussion_r648922768



##########
File path: hw/mcu/nordic/nrf5340/pkg.yml
##########
@@ -104,3 +104,10 @@ pkg.deps.I2C_3':
 
 pkg.deps.NRF5340_EMBED_NET_CORE:
     - "@apache-mynewt-core/hw/mcu/nordic/nrf5340/net_core_image"
+
+# As per Errata 26 for Engineering RevA silicon we should not
+# depend on CTRL-AP: APPROTECT.DISABLE and SECUREAPPROTECT.DISABLE
+# registers since they are not functional. It causes quite a lot of
+# crashes and hardfaults
+pkg.cflags.MCU_NRF5340_REVA_SILICON:

Review comment:
       I'd not make this as revA workaround but rather a general config as provided by nrfx:  enabled, user controlled and UICR controlled. 

##########
File path: hw/mcu/nordic/nrf5340/syscfg.yml
##########
@@ -25,13 +25,15 @@ syscfg.defs:
             - $notnull
         choices:
             - nRF5340_APP
+
     MCU_APP_CORE:
         description: >
             Constant value always set to 1.  It allows to have common
             packages for network and application core that do have
             some differences depending on which core they are build for.
         value: 1
         restriction: MCU_NET_CORE==0

Review comment:
       isn't the real problem a typo above?  restriction_S_   ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org