[commons-lang] branch master updated: Make private elements final where possible.

[gg...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git


The following commit(s) were added to refs/heads/master by this push:
     new 0b135af  Make private elements final where possible.
0b135af is described below

commit 0b135af5a0553d9882efef13e60a464986e6af36
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Jan 17 16:48:52 2021 -0500

    Make private elements final where possible.
---
 src/main/java/org/apache/commons/lang3/time/FormatCache.java          | 2 +-
 .../java/org/apache/commons/lang3/builder/CompareToBuilderTest.java   | 2 +-
 src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java | 4 ++--
 .../java/org/apache/commons/lang3/builder/ToStringBuilderTest.java    | 4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/main/java/org/apache/commons/lang3/time/FormatCache.java b/src/main/java/org/apache/commons/lang3/time/FormatCache.java
index ffe41e3..f2f3d8a 100644
--- a/src/main/java/org/apache/commons/lang3/time/FormatCache.java
+++ b/src/main/java/org/apache/commons/lang3/time/FormatCache.java
@@ -225,7 +225,7 @@ abstract class FormatCache<F extends Format> {
         }
 
         private final Object[] keys;
-        private int hashCode;
+        private final int hashCode;
 
         /**
          * Constructs an instance of {@code MultipartKey} to hold the specified objects.
diff --git a/src/test/java/org/apache/commons/lang3/builder/CompareToBuilderTest.java b/src/test/java/org/apache/commons/lang3/builder/CompareToBuilderTest.java
index 7311ee3..c7dee69 100644
--- a/src/test/java/org/apache/commons/lang3/builder/CompareToBuilderTest.java
+++ b/src/test/java/org/apache/commons/lang3/builder/CompareToBuilderTest.java
@@ -90,7 +90,7 @@ public class CompareToBuilderTest {
 
     static class TestTransientSubObject extends TestObject {
         @SuppressWarnings("unused")
-        private transient int t;
+        private final transient int t;
         TestTransientSubObject(final int a, final int t) {
             super(a);
             this.t = t;
diff --git a/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java b/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java
index f0fab39..af64ddd 100644
--- a/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java
+++ b/src/test/java/org/apache/commons/lang3/builder/EqualsBuilderTest.java
@@ -125,7 +125,7 @@ public class EqualsBuilderTest {
 
     static class TestTSubObject extends TestObject {
         @SuppressWarnings("unused")
-        private transient int t;
+        private final transient int t;
 
         TestTSubObject(final int a, final int t) {
             super(a);
@@ -135,7 +135,7 @@ public class EqualsBuilderTest {
 
     static class TestTTSubObject extends TestTSubObject {
         @SuppressWarnings("unused")
-        private transient int tt;
+        private final transient int tt;
 
         TestTTSubObject(final int a, final int t, final int tt) {
             super(a, t);
diff --git a/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java b/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java
index 4ca52bd..81ef98f 100644
--- a/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java
+++ b/src/test/java/org/apache/commons/lang3/builder/ToStringBuilderTest.java
@@ -357,14 +357,14 @@ public class ToStringBuilderTest {
         @SuppressWarnings("unused")
         private final char a='a';
         @SuppressWarnings("unused")
-        private transient char transientA='t';
+        private final transient char transientA='t';
     }
 
     static class ReflectionTestFixtureB extends ReflectionTestFixtureA {
         @SuppressWarnings("unused")
         private final char b='b';
         @SuppressWarnings("unused")
-        private transient char transientB='t';
+        private final transient char transientB='t';
     }
 
     @Test