You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/05/18 09:37:04 UTC
[GitHub] [helix] huizhilu opened a new pull request #1745: Add live instance data change listener
huizhilu opened a new pull request #1745:
URL: https://github.com/apache/helix/pull/1745
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
Resolves #1743
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
For cluster pause mode feature: controller needs to listen to the live instance status change and resume the cluster from pause mode upon all live instances fully exit pause mode.
Add a new listener to controller and implement the callback. Listener type: DataChange
### Tests
- [ ] The following tests are written for this issue:
testLiveInstanceDataChangeListener
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on a change in pull request #1745: Add live instance data change listener
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on a change in pull request #1745:
URL: https://github.com/apache/helix/pull/1745#discussion_r634661185
##########
File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -1185,6 +1191,18 @@ public void onClusterConfigChange(ClusterConfig clusterConfig,
.info("END: GenericClusterController.onClusterConfigChange() for cluster " + _clusterName);
}
+ @Override
+ @PreFetch(enabled = false)
+ public void onLiveInstanceDataChange(LiveInstance liveInstance, NotificationContext context) {
+ logger.info("START: GenericClusterController.onLiveInstanceDataChange() for cluster {}",
+ _clusterName);
+ // Selectively refresh live instances cache.
+ notifyCaches(context, ChangeType.LIVE_INSTANCE);
+ pushToEventQueues(ClusterEventType.LiveInstanceChange, context, Collections.emptyMap());
Review comment:
Do we want to reuse the previous event type? If this is a new use case, we can have a new event type to distinguish individual instance data change from previous live instance children change.
##########
File path: helix-core/src/test/java/org/apache/helix/TestListenerCallback.java
##########
@@ -275,4 +279,29 @@ public void testScopedConfigChangeListener() throws Exception {
"Should get resourceConfig callback invoked since we add resourceConfig");
Assert.assertEquals(listener._configSize, 0, "Resource Config size does not match");
}
+
+ @Test
+ public void testLiveInstanceDataChangeListener() {
+ // start 1 participant
+ String instanceName = "localhost_" + 12918;
+ MockParticipantManager participant =
+ new MockParticipantManager(ZK_ADDR, _clusterName, instanceName);
+ participant.syncStart();
+
+ HelixDataAccessor accessor = _manager.getHelixDataAccessor();
+ LiveInstance liveInstance =
+ accessor.getProperty(accessor.keyBuilder().liveInstance(instanceName));
+ AtomicBoolean liveInstanceDataChangeNotified = new AtomicBoolean(false);
+
+ // add live instance data change listener and update live instance
+ LiveInstanceDataChangeListener listener =
+ (liveInstanceChanged, notificationContext) -> liveInstanceDataChangeNotified.set(true);
+ _manager.addLiveInstanceDataChangeListener(listener, instanceName);
+ accessor.updateProperty(accessor.keyBuilder().liveInstance(instanceName), liveInstance);
+
+ Assert.assertTrue(liveInstanceDataChangeNotified.get());
Review comment:
I would suggest to use TestHelper.verify(() instead of directly "assert" to validate the results so that the test is more stable. You can take a look at other test cases in this file as an example.
##########
File path: helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java
##########
@@ -267,6 +269,13 @@ private void parseListenerProperties() {
break;
case CONTROLLER:
listenerClass = ControllerChangeListener.class;
+ break;
+ case LIVE_INSTANCE_DATA:
+ listenerClass = LiveInstanceDataChangeListener.class;
+ break;
+ default:
+ logger.warn("Unexpected change type {} in callback {}", _changeType, _uid);
Review comment:
This is a new case. I think if we do arrive at this case, we should log it as an error.
##########
File path: helix-core/src/main/java/org/apache/helix/HelixManager.java
##########
@@ -129,6 +132,15 @@
*/
void addLiveInstanceChangeListener(LiveInstanceChangeListener listener) throws Exception;
+ /**
+ * @see LiveInstanceDataChangeListener#onLiveInstanceDataChange(LiveInstance, NotificationContext)
+ * @param listener {@link LiveInstanceDataChangeListener}
+ */
+ default void addLiveInstanceDataChangeListener(LiveInstanceDataChangeListener listener,
+ String instanceName) {
+ throw new NotImplementedException("Not implemented");
Review comment:
This line is unnecessary, as following the pattern for most other listeners in this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] huizhilu closed pull request #1745: Add live instance data change listener
Posted by GitBox <gi...@apache.org>.
huizhilu closed pull request #1745:
URL: https://github.com/apache/helix/pull/1745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org