You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/01/14 17:20:05 UTC
[GitHub] [couchdb-fauxton] mhamann opened a new pull request #1246: Nav: Fix
potential ID selector collisions
mhamann opened a new pull request #1246: Nav: Fix potential ID selector collisions
URL: https://github.com/apache/couchdb-fauxton/pull/1246
## Overview
If a design doc is created with a name that conflicts with an existing HTML element's ID, it will receive the styling for that element in addition to causing invalid HTML.
In my case, I'd created a design doc named `dashboard`, which then produced a navigation item with an ID of `#dashboard`. This conflicts with the existing `#dashboard` element, which has several CSS styles applied. It then breaks the navigation layout (see screenshot). It becomes impossible to edit the views within the design doc without manually editing the UI.
This change prefixes those IDs in order to ensure they
are unique.
## Testing recommendations
Tested the UI locally to ensure the rendering was fixed and that I could still access my docs, views, etc.
## GitHub issue number
N/A
## Related Pull Requests
N/A
## Checklist
- [x] Code is written and works correctly;
- [ ] Changes are covered by tests;
- [ ] Documentation reflects the changes;
- [ ] Update [rebar.config.script](https://github.com/apache/couchdb/blob/master/rebar.config.script) with the correct tag once a new Fauxton release is made
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-fauxton] willholley commented on issue #1246: Nav: Fix
potential ID selector collisions
Posted by GitBox <gi...@apache.org>.
willholley commented on issue #1246: Nav: Fix potential ID selector collisions
URL: https://github.com/apache/couchdb-fauxton/pull/1246#issuecomment-575257355
@mhamann https://travis-ci.org/apache/couchdb-fauxton/jobs/637256303 (test suite running against couchdb + search) fails consistently with this branch but passes on master (after some retries). It seems likely this is just general flakiness; @Antonio-Maranhao do you have any suggestions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-fauxton] willholley commented on issue #1246: Nav: Fix
potential ID selector collisions
Posted by GitBox <gi...@apache.org>.
willholley commented on issue #1246: Nav: Fix potential ID selector collisions
URL: https://github.com/apache/couchdb-fauxton/pull/1246#issuecomment-575091751
nice catch - thanks @mhamann.
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-fauxton] mhamann commented on issue #1246: Nav: Fix
potential ID selector collisions
Posted by GitBox <gi...@apache.org>.
mhamann commented on issue #1246: Nav: Fix potential ID selector collisions
URL: https://github.com/apache/couchdb-fauxton/pull/1246#issuecomment-580840096
@willholley got a clean build after my last commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-fauxton] willholley commented on issue #1246: Nav: Fix
potential ID selector collisions
Posted by GitBox <gi...@apache.org>.
willholley commented on issue #1246: Nav: Fix potential ID selector collisions
URL: https://github.com/apache/couchdb-fauxton/pull/1246#issuecomment-575181746
something's not quite right in the CI here - it's consistently failing when search is enabled. I'm running the Jenkins build against master to verify that it's not a general issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-fauxton] willholley commented on issue #1246: Nav: Fix
potential ID selector collisions
Posted by GitBox <gi...@apache.org>.
willholley commented on issue #1246: Nav: Fix potential ID selector collisions
URL: https://github.com/apache/couchdb-fauxton/pull/1246#issuecomment-579854947
@mhamann the nightwatch tests [for search indexes](https://github.com/apache/couchdb-fauxton/tree/master/app/addons/search/tests/nightwatch). Can you update your PR to patch them similarly to the view tests and then we can merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-fauxton] willholley merged pull request #1246: Nav: Fix
potential ID selector collisions
Posted by GitBox <gi...@apache.org>.
willholley merged pull request #1246: Nav: Fix potential ID selector collisions
URL: https://github.com/apache/couchdb-fauxton/pull/1246
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-fauxton] mhamann commented on issue #1246: Nav: Fix
potential ID selector collisions
Posted by GitBox <gi...@apache.org>.
mhamann commented on issue #1246: Nav: Fix potential ID selector collisions
URL: https://github.com/apache/couchdb-fauxton/pull/1246#issuecomment-575226180
@willholley I had some trouble running the nightwatch tests locally, so I had to update a couple of test cases based on failures I noticed in Travis. It's possible I may still have missed something...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-fauxton] willholley commented on issue #1246: Nav: Fix
potential ID selector collisions
Posted by GitBox <gi...@apache.org>.
willholley commented on issue #1246: Nav: Fix potential ID selector collisions
URL: https://github.com/apache/couchdb-fauxton/pull/1246#issuecomment-581032409
@mhamann perfect -thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services