You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Benjamin Mahler (JIRA)" <ji...@apache.org> on 2015/01/16 20:57:34 UTC
[jira] [Commented] (MESOS-2232) Suppress
MockAllocator::transformAllocation() warnings.
[ https://issues.apache.org/jira/browse/MESOS-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14280740#comment-14280740 ]
Benjamin Mahler commented on MESOS-2232:
----------------------------------------
Sorry for the noise here.
Note that most of our other mocks do not have uninteresting calls because we used EXPECT_CALL instead of ON_CALL:
https://github.com/apache/mesos/blob/0.21.1/src/tests/containerizer.cpp#L220
The only mock that still uses ON_CALL is the allocator mock, IIRC:
https://github.com/apache/mesos/blob/0.21.1/src/tests/mesos.hpp#L654
I can't recall if there was a reason for not updating this mock, but I'll take a look.
> Suppress MockAllocator::transformAllocation() warnings.
> -------------------------------------------------------
>
> Key: MESOS-2232
> URL: https://issues.apache.org/jira/browse/MESOS-2232
> Project: Mesos
> Issue Type: Bug
> Components: test
> Reporter: Alexander Rukletsov
> Priority: Minor
>
> After transforming allocated resources feature was added to allocator, a number of warnings are popping out for allocator tests. Commits leading to this behaviour:
> {{dacc88292cc13d4b08fe8cda4df71110a96cb12a}}
> {{5a02d5bdc75d3b1149dcda519016374be06ec6bd}}
> corresponding reviews:
> https://reviews.apache.org/r/29083
> https://reviews.apache.org/r/29084
> Here is an example:
> {code}
> [ RUN ] MasterAllocatorTest/0.FrameworkReregistersFirst GMOCK WARNING: Uninteresting mock function call - taking default action specified at: ../../../src/tests/mesos.hpp:719: Function call: transformAllocation(@0x7fd3bb5274d8 20150115-185632-1677764800-59671-44186-0000, @0x7fd3bb5274f8 20150115-185632-1677764800-59671-44186-S0, @0x1119140e0 16-byte object <F0-5E 52-BB D3-7F 00-00 C0-5F 52-BB D3-7F 00-00>) Stack trace: [ OK ] MasterAllocatorTest/0.FrameworkReregistersFirst (204 ms)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)