You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2009/05/04 15:22:30 UTC

[jira] Commented: (HADOOP-5664) Use of ReentrantLock.lock() in MapOutputBuffer takes up too much cpu time

    [ https://issues.apache.org/jira/browse/HADOOP-5664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705584#action_12705584 ] 

Hadoop QA commented on HADOOP-5664:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12406339/5664-0.patch
  against trunk revision 771231.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/286/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/286/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/286/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/286/console

This message is automatically generated.

> Use of ReentrantLock.lock() in MapOutputBuffer takes up too much cpu time
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-5664
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5664
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.19.1
>            Reporter: Bryan Duxbury
>            Assignee: Chris Douglas
>            Priority: Minor
>         Attachments: 5664-0.patch
>
>
> In examining a profile of one of my mappers today, I noticed that the method ReentrantLock.lock() in MapTask$MapOutputBuffer seems to be taking up ~11 seconds out of around 100 seconds total. It seems like 10% is an awfully large amount of time to spend in this lock. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.