[GitHub] [yunikorn-core] craigcondit commented on a diff in pull request #446: [YUNIKORN-1366] Read core configuration from shim

[GitBox <gi...@apache.org>]

craigcondit commented on code in PR #446:
URL: https://github.com/apache/yunikorn-core/pull/446#discussion_r1017235498


##########
pkg/entrypoint/entrypoint.go:
##########
@@ -55,6 +55,10 @@ func StartAllServicesWithLogger(logger *zap.Logger, zapConfigs *zap.Config) *Ser
 	return StartAllServices()
 }
 
+func InitializeLogger(logger *zap.Logger, zapConfigs *zap.Config) {
+	log.InitializeLogger(logger, zapConfigs)
+}
+

Review Comment:
   It gets called in the updated shim code when the configuration changes, so it's needed here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org