[GitHub] [pulsar] tisonkun commented on a diff in pull request #19051: [fix][client] retry letter producer respect auto schema

[GitBox <gi...@apache.org>]

tisonkun commented on code in PR #19051:
URL: https://github.com/apache/pulsar/pull/19051#discussion_r1056973867


##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/RetryTopicTest.java:
##########
@@ -128,6 +133,100 @@ public void testRetryTopic() throws Exception {
         checkConsumer.close();
     }
 
+    @Data
+    public static class Foo {
+        @Nullable
+        private String field1;
+        @Nullable
+        private String field2;
+    }
+
+    @Data
+    public static class FooV2 {
+        @Nullable
+        private String field1;
+        @Nullable
+        private String field2;
+        @Nullable
+        private String field3;
+    }
+
+    @Test(timeOut = 20000)
+    public void testAutoConsumeSchemaRetryLetter() throws Exception {
+        final String topic = "persistent://my-property/my-ns/retry-letter-topic";
+        final String subName = "my-subscription";
+        final int maxRedeliveryCount = 1;
+        final int sendMessages = 10;
+
+        admin.topics().createNonPartitionedTopic(topic);
+
+        @Cleanup
+        PulsarClient newPulsarClient = newPulsarClient(lookupUrl.toString(), 0);// Creates new client connection
+        Consumer<FooV2> deadLetterConsumer = newPulsarClient.newConsumer(Schema.AVRO(FooV2.class))

Review Comment:
   I follow the test pattern from `testRetryTopic` and `testAutoConsumeSchemaDeadLetter`. Even `testRetryTopic` set up the DLQ.
   
   May you directly submit a patch onto this pull request?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org