You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "Jarek Potiuk (Jira)" <ji...@apache.org> on 2019/12/29 13:01:00 UTC

[jira] [Updated] (AIRFLOW-6392) Remove cyclic module dependency airfllow.models.baseoperator <-> airflow.utils.helpers

     [ https://issues.apache.org/jira/browse/AIRFLOW-6392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Potiuk updated AIRFLOW-6392:
----------------------------------
    Description: 
There is a hidden cyclic dependency between baseoperator and helpers module. It's hidden by local import but it is detected when baseoperator/helpers are removed from pylint_todo.txt (and it's really there). 

The dependency comes from BaseOperator using helpers and two helpers methods (chain and cross_downstream) using BaseOperator. This can be solved by converting the chain and cross_downstream methods to be static methods in BaseOperator class.

  was:There is a hidden cyclic dependency between baseoperator and helpers module. It's hidden by local import but it is detected when baseoperator/helpers are removed from pylint_todo.txt (and it's really there). 


> Remove cyclic module dependency airfllow.models.baseoperator <-> airflow.utils.helpers
> --------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-6392
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6392
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: ci
>    Affects Versions: 2.0.0
>            Reporter: Jarek Potiuk
>            Priority: Major
>
> There is a hidden cyclic dependency between baseoperator and helpers module. It's hidden by local import but it is detected when baseoperator/helpers are removed from pylint_todo.txt (and it's really there). 
> The dependency comes from BaseOperator using helpers and two helpers methods (chain and cross_downstream) using BaseOperator. This can be solved by converting the chain and cross_downstream methods to be static methods in BaseOperator class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)