You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/09/05 03:45:49 UTC

[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #192: [ISSUE-186][Feature] Use I/O cost time to select storage paths

jerqi commented on code in PR #192:
URL: https://github.com/apache/incubator-uniffle/pull/192#discussion_r962453592


##########
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorConf.java:
##########
@@ -125,7 +125,21 @@ public class CoordinatorConf extends RssBaseConf {
       .stringType()
       .noDefaultValue()
       .withDescription("Remote Storage Cluster related conf with format $clusterId,$key=$value, separated by ';'");
-
+  public static final ConfigOption<String> COORDINATOR_REMOTE_STORAGE_SELECT_STRATEGY = ConfigOptions
+      .key("rss.coordinator.remote.storage.select.strategy")
+      .stringType()
+      .defaultValue("IO")

Review Comment:
   Could we use "APP" as default value?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org