[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #3815: API: Upgrade Guava to use murmur3_32_fixed

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #3815:
URL: https://github.com/apache/iceberg/pull/3815#discussion_r778416930



##########
File path: api/src/main/java/org/apache/iceberg/transforms/Bucket.java
##########
@@ -41,7 +41,7 @@
 import static org.apache.iceberg.types.Type.TypeID;
 
 abstract class Bucket<T> implements Transform<T, Integer> {
-  private static final HashFunction MURMUR3 = Hashing.murmur3_32();
+  private static final HashFunction MURMUR3 = Hashing.murmur3_32_fixed();

Review comment:
       @findepi I was just going through the trino code and noticed it uses a different [Murmur3 Implementation](https://github.com/trinodb/trino/blob/fb88c0bf589db55d77223fc31aab29acbb2d0698/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/PartitionTransforms.java#L422), does this match the fixed version here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org