You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Scott O'Bryan (JIRA)" <ad...@incubator.apache.org> on 2007/01/25 21:09:49 UTC
[jira] Created: (ADFFACES-364) PartialPageContext optimization bug
PartialPageContext optimization bug
-----------------------------------
Key: ADFFACES-364
URL: https://issues.apache.org/jira/browse/ADFFACES-364
Project: MyFaces ADF-Faces
Issue Type: Bug
Components: Portlet
Environment: JSR-168
Reporter: Scott O'Bryan
Currently there is no container agnostic way of handling PPR in a JSR-168 Portal. Therefore, Trinidad has PPR disabled. One can create extensions to Trinidad, however, which would support PPR in a container-specific fashion. In these environments, it should be possible to retrieve a PartialPageContext in a portal environment as this object has uses to Trinidad extension. The optimization inside of CoreRenderingContext returns null when the Trinidad Portal capability is not enabled. This optimization should be removed.
This will not impact the performance of the system NOR will it impact the API. This is because the Trinidad renderkit will already not SEND a ppr request in a portal environment, so it will never "attempt" to retrieve the PartialPageContext in a portal environment. If a Trinidad EXTENSION should generate a portal-compatible PPR request, it will need to FORCE the PPR request using Trinidad API's before it retrieves the PartialPageContext or Trinidad will return null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-364) PartialPageContext optimization bug
Posted by "Scott O'Bryan (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott O'Bryan updated ADFFACES-364:
-----------------------------------
Status: Patch Available (was: Open)
> PartialPageContext optimization bug
> -----------------------------------
>
> Key: ADFFACES-364
> URL: https://issues.apache.org/jira/browse/ADFFACES-364
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Portlet
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Attachments: 10-ADFFACES-364.patch
>
>
> Currently there is no container agnostic way of handling PPR in a JSR-168 Portal. Therefore, Trinidad has PPR disabled. One can create extensions to Trinidad, however, which would support PPR in a container-specific fashion. In these environments, it should be possible to retrieve a PartialPageContext in a portal environment as this object has uses to Trinidad extension. The optimization inside of CoreRenderingContext returns null when the Trinidad Portal capability is not enabled. This optimization should be removed.
> This will not impact the performance of the system NOR will it impact the API. This is because the Trinidad renderkit will already not SEND a ppr request in a portal environment, so it will never "attempt" to retrieve the PartialPageContext in a portal environment. If a Trinidad EXTENSION should generate a portal-compatible PPR request, it will need to FORCE the PPR request using Trinidad API's before it retrieves the PartialPageContext or Trinidad will return null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ADFFACES-364) PartialPageContext optimization
bug
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467988 ]
Adam Winer commented on ADFFACES-364:
-------------------------------------
I don't know that I agree with the logic here. Have you checked all of the code to make sure that it doesn't force a PPR request? I don't think that this was added as an optimization.
For example, in CommandLinkRenderer.decode():
if (getPartialSubmit(getFacesBean(component)))
{
PartialPageUtils.forcePartialRendering(context);
}
... which would, I believe, break if you remove that line.
> PartialPageContext optimization bug
> -----------------------------------
>
> Key: ADFFACES-364
> URL: https://issues.apache.org/jira/browse/ADFFACES-364
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Portlet
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Attachments: 10-ADFFACES-364.patch, 10-ADFFACES-364.patch
>
>
> Currently there is no container agnostic way of handling PPR in a JSR-168 Portal. Therefore, Trinidad has PPR disabled. One can create extensions to Trinidad, however, which would support PPR in a container-specific fashion. In these environments, it should be possible to retrieve a PartialPageContext in a portal environment as this object has uses to Trinidad extension. The optimization inside of CoreRenderingContext returns null when the Trinidad Portal capability is not enabled. This optimization should be removed.
> This will not impact the performance of the system NOR will it impact the API. This is because the Trinidad renderkit will already not SEND a ppr request in a portal environment, so it will never "attempt" to retrieve the PartialPageContext in a portal environment. If a Trinidad EXTENSION should generate a portal-compatible PPR request, it will need to FORCE the PPR request using Trinidad API's before it retrieves the PartialPageContext or Trinidad will return null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-364) PartialPageContext optimization bug
Posted by "Scott O'Bryan (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott O'Bryan updated ADFFACES-364:
-----------------------------------
Attachment: 10-ADFFACES-364.patch
This patch removes the erroneous optimization
> PartialPageContext optimization bug
> -----------------------------------
>
> Key: ADFFACES-364
> URL: https://issues.apache.org/jira/browse/ADFFACES-364
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Portlet
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Attachments: 10-ADFFACES-364.patch
>
>
> Currently there is no container agnostic way of handling PPR in a JSR-168 Portal. Therefore, Trinidad has PPR disabled. One can create extensions to Trinidad, however, which would support PPR in a container-specific fashion. In these environments, it should be possible to retrieve a PartialPageContext in a portal environment as this object has uses to Trinidad extension. The optimization inside of CoreRenderingContext returns null when the Trinidad Portal capability is not enabled. This optimization should be removed.
> This will not impact the performance of the system NOR will it impact the API. This is because the Trinidad renderkit will already not SEND a ppr request in a portal environment, so it will never "attempt" to retrieve the PartialPageContext in a portal environment. If a Trinidad EXTENSION should generate a portal-compatible PPR request, it will need to FORCE the PPR request using Trinidad API's before it retrieves the PartialPageContext or Trinidad will return null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ADFFACES-364) PartialPageContext optimization
bug
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467676 ]
Jeanne Waldman commented on ADFFACES-364:
-----------------------------------------
Applied patch to jwaldman-portal branch.
> PartialPageContext optimization bug
> -----------------------------------
>
> Key: ADFFACES-364
> URL: https://issues.apache.org/jira/browse/ADFFACES-364
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Portlet
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Attachments: 10-ADFFACES-364.patch, 10-ADFFACES-364.patch
>
>
> Currently there is no container agnostic way of handling PPR in a JSR-168 Portal. Therefore, Trinidad has PPR disabled. One can create extensions to Trinidad, however, which would support PPR in a container-specific fashion. In these environments, it should be possible to retrieve a PartialPageContext in a portal environment as this object has uses to Trinidad extension. The optimization inside of CoreRenderingContext returns null when the Trinidad Portal capability is not enabled. This optimization should be removed.
> This will not impact the performance of the system NOR will it impact the API. This is because the Trinidad renderkit will already not SEND a ppr request in a portal environment, so it will never "attempt" to retrieve the PartialPageContext in a portal environment. If a Trinidad EXTENSION should generate a portal-compatible PPR request, it will need to FORCE the PPR request using Trinidad API's before it retrieves the PartialPageContext or Trinidad will return null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (ADFFACES-364) PartialPageContext optimization bug
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Winer closed ADFFACES-364.
-------------------------------
Resolution: Invalid
"forcePartialRendering" only means "force it if PPR is really supported". I don't think we have a problem here.
> PartialPageContext optimization bug
> -----------------------------------
>
> Key: ADFFACES-364
> URL: https://issues.apache.org/jira/browse/ADFFACES-364
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Portlet
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Attachments: 10-ADFFACES-364.patch, 10-ADFFACES-364.patch
>
>
> Currently there is no container agnostic way of handling PPR in a JSR-168 Portal. Therefore, Trinidad has PPR disabled. One can create extensions to Trinidad, however, which would support PPR in a container-specific fashion. In these environments, it should be possible to retrieve a PartialPageContext in a portal environment as this object has uses to Trinidad extension. The optimization inside of CoreRenderingContext returns null when the Trinidad Portal capability is not enabled. This optimization should be removed.
> This will not impact the performance of the system NOR will it impact the API. This is because the Trinidad renderkit will already not SEND a ppr request in a portal environment, so it will never "attempt" to retrieve the PartialPageContext in a portal environment. If a Trinidad EXTENSION should generate a portal-compatible PPR request, it will need to FORCE the PPR request using Trinidad API's before it retrieves the PartialPageContext or Trinidad will return null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-364) PartialPageContext optimization bug
Posted by "Scott O'Bryan (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott O'Bryan updated ADFFACES-364:
-----------------------------------
Attachment: 10-ADFFACES-364.patch
Fixed a minor bug with this patch
> PartialPageContext optimization bug
> -----------------------------------
>
> Key: ADFFACES-364
> URL: https://issues.apache.org/jira/browse/ADFFACES-364
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Portlet
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Attachments: 10-ADFFACES-364.patch, 10-ADFFACES-364.patch
>
>
> Currently there is no container agnostic way of handling PPR in a JSR-168 Portal. Therefore, Trinidad has PPR disabled. One can create extensions to Trinidad, however, which would support PPR in a container-specific fashion. In these environments, it should be possible to retrieve a PartialPageContext in a portal environment as this object has uses to Trinidad extension. The optimization inside of CoreRenderingContext returns null when the Trinidad Portal capability is not enabled. This optimization should be removed.
> This will not impact the performance of the system NOR will it impact the API. This is because the Trinidad renderkit will already not SEND a ppr request in a portal environment, so it will never "attempt" to retrieve the PartialPageContext in a portal environment. If a Trinidad EXTENSION should generate a portal-compatible PPR request, it will need to FORCE the PPR request using Trinidad API's before it retrieves the PartialPageContext or Trinidad will return null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ADFFACES-364) PartialPageContext optimization
bug
Posted by "Scott O'Bryan (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468849 ]
Scott O'Bryan commented on ADFFACES-364:
----------------------------------------
Sorry Adam, I just noticed this comment.
I'm not sure that the code above is causing an issue, but you are correct about the assumptions. I think the "poll" component will break since it basically does no checking at all. I'm having Jeanne reverse this change and I'll have to find another way to provide this functionality.
If you could give me your input though, I would be much appreciative. There are a handful of places where we forcePartialRendering in Trinidad. Do you think it would be acceptable to figure out whether the PPR capability is enabled BEFORE forcingPartialRendering is executed? I mean when I see a "forcePartialRendering" method, I assume it's actually going to Force us into a Partial Rendering state regardless of capabilities.
Scott
> PartialPageContext optimization bug
> -----------------------------------
>
> Key: ADFFACES-364
> URL: https://issues.apache.org/jira/browse/ADFFACES-364
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Portlet
> Environment: JSR-168
> Reporter: Scott O'Bryan
> Attachments: 10-ADFFACES-364.patch, 10-ADFFACES-364.patch
>
>
> Currently there is no container agnostic way of handling PPR in a JSR-168 Portal. Therefore, Trinidad has PPR disabled. One can create extensions to Trinidad, however, which would support PPR in a container-specific fashion. In these environments, it should be possible to retrieve a PartialPageContext in a portal environment as this object has uses to Trinidad extension. The optimization inside of CoreRenderingContext returns null when the Trinidad Portal capability is not enabled. This optimization should be removed.
> This will not impact the performance of the system NOR will it impact the API. This is because the Trinidad renderkit will already not SEND a ppr request in a portal environment, so it will never "attempt" to retrieve the PartialPageContext in a portal environment. If a Trinidad EXTENSION should generate a portal-compatible PPR request, it will need to FORCE the PPR request using Trinidad API's before it retrieves the PartialPageContext or Trinidad will return null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.