[GitHub] [logging-log4cxx] rm5248 commented on a change in pull request #24: Implement mapfilter

[GitBox <gi...@apache.org>]

rm5248 commented on a change in pull request #24:
URL: https://github.com/apache/logging-log4cxx/pull/24#discussion_r436224245



##########
File path: src/main/include/log4cxx/filter/mapfilter.h
##########
@@ -19,26 +19,87 @@
 
 #include <log4cxx/spi/filter.h>
 
+#if defined(_MSC_VER)
+	#pragma warning ( push )
+	#pragma warning ( disable: 4251 )
+#endif
+
 namespace log4cxx
 {
 namespace filter
 {
+/**
+ * A Filter that operates on a Map.
+ */
 
+using KeyValList = std::map<LogString, LogString>;

Review comment:
       Using 'using' inside of a header is generally bad practice; in this case though, while it may be okay I don't see the point of creating a new type(this is equivalent to `typedef KeyValList std::map<LogString,LogString>`).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org