[GitHub] [flink] tillrohrmann commented on issue #10073: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink-conf.yaml is set to zero will cause taskmanager not to work

[GitBox <gi...@apache.org>]

tillrohrmann commented on issue #10073: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink-conf.yaml is set to zero will cause taskmanager not to work
URL: https://github.com/apache/flink/pull/10073#issuecomment-549284526
 
 
   @faaronzheng I think `LEGACY_MANAGED_MEMORY_SIZE` still has a default value: https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java#L195.
   
   I would propose the following: Let's remove the default value from `LEGACY_MANAGED_MEMORY_SIZE` in `master` and from `MANAGED_MEMORY_SIZE` in `release-1.9`. Then let's update the code to simply check whether `(LEGACY_)MANAGED_MEMORY_SIZE` has been set or not instead of comparing the default values with each other. Could you update this PR accordingly and open another one against `release-1.9`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services