You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/31 17:29:22 UTC
[GitHub] [arrow] nmcdonnell-kx opened a new pull request #9382: Arrow 3.0.0 build failing on Windows
nmcdonnell-kx opened a new pull request #9382:
URL: https://github.com/apache/arrow/pull/9382
Missing include file:
```
24>C:\Git\arrow3.0.0\cpp\src\arrow\util\tdigest.cc(224,12): error C2039: 'tie': is not a member of 'std'
24>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29333\include\queue(22): message : see declaration of 'std'
24>C:\Git\arrow3.0.0\cpp\src\arrow\util\tdigest.cc(224,1): error C3861: 'tie': identifier not found
24>C:\Git\arrow3.0.0\cpp\src\arrow\util\tdigest.cc(233,12): error C2039: 'tie': is not a member of 'std'
24>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.28.29333\include\queue(22): message : see declaration of 'std'
24>C:\Git\arrow3.0.0\cpp\src\arrow\util\tdigest.cc(233,1): error C3861: 'tie': identifier not found
```
Arrow version:
```
C:\Git\arrow3.0.0\cpp\build>git describe
apache-arrow-3.0.0-94-g51e911892
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #9382: ARROW-11448: [C++] Fix tdigest build failure on Windows with Visual Studio
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #9382:
URL: https://github.com/apache/arrow/pull/9382#discussion_r567545562
##########
File path: cpp/src/arrow/util/tdigest.cc
##########
@@ -21,6 +21,7 @@
#include <cmath>
#include <iostream>
#include <queue>
+#include <tuple>
Review comment:
Maybe, `-DCMAKE_UNITY_BUILD=ON` hides this problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9382: ARROW-11448: [C++] Arrow C++ 3.0.0 build failing on Windows with Visual Studio
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9382:
URL: https://github.com/apache/arrow/pull/9382#issuecomment-770426187
https://issues.apache.org/jira/browse/ARROW-11448
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on a change in pull request #9382: ARROW-11448: [C++] Arrow C++ 3.0.0 build failing on Windows with Visual Studio
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on a change in pull request #9382:
URL: https://github.com/apache/arrow/pull/9382#discussion_r567526432
##########
File path: cpp/src/arrow/util/tdigest.cc
##########
@@ -21,6 +21,7 @@
#include <cmath>
#include <iostream>
#include <queue>
+#include <tuple>
Review comment:
Thanks for fixing it.
It's strange why CI doesn't find this error when I uploaded the original patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #9382: ARROW-11448: [C++] Fix tdigest build failure on Windows with Visual Studio
Posted by GitBox <gi...@apache.org>.
kou closed pull request #9382:
URL: https://github.com/apache/arrow/pull/9382
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9382: Arrow 3.0.0 build failing on Windows
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9382:
URL: https://github.com/apache/arrow/pull/9382#issuecomment-770418061
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org