You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/01/19 17:30:39 UTC
[GitHub] [trafficcontrol] shamrickus opened a new pull request #6514: Fix traffic_portal audit issues and remove un-needed deps
shamrickus opened a new pull request #6514:
URL: https://github.com/apache/trafficcontrol/pull/6514
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
This PR fixes the 22 vulnerabilities (12 high, 3 critical) found by
`npm audit`. It also removes TP dependencies that are not used.
Changelogs for updates (all breaking changes are not relevant):
[bootstrap-sass](https://github.com/twbs/bootstrap-sass/releases), [es5-shim](https://github.com/es-shims/es5-shim/blob/master/CHANGELOG.md), [express](https://github.com/expressjs/express/releases), [font-awesome](https://github.com/FortAwesome/Font-Awesome/tree/fa-4#changelog), [grunt-brwoserify](https://github.com/jmreidy/grunt-browserify/tags), [grunt-html2js](https://github.com/rquadling/grunt-html2js/releases), [grunt](https://github.com/gruntjs/grunt/blob/main/CHANGELOG), [json3](https://www.npmjs.com/package/json3), [load-grunt-config](https://github.com/firstandthird/load-grunt-config/blob/master/CHANGELOG.md), [sass](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md), [time-grunt](https://github.com/sindresorhus/time-grunt/tags)
Removed:
`grunt-concurrent`, `grunt-contrib-concat`, `grunt-contrib-cssmin`, `grunt-contrib-jsmin`, `grunt-contrib-uglify`, `grunt-contrib-htmlmin`, `grunt-newer`, `grunt-contrib-jshint` and `grunt-wiredep`
Note: `t_p/app/src/package.json` contains the required node_modules to run the server portion of TP. `t_p/app/package.json` also needs these deps for the build process even though it's not actually needed for the front end. As such the versions of these two files should always match.
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Traffic Portal
## What is the best way to verify this PR?
Build TP in both dev and prod mode. Verify both still work, run tests and make sure they still work. Verify `npm audit` returns 0 issues.
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
## If this is a bugfix, which Traffic Control versions contained the bug?
<!-- Delete this section if the PR is not a bugfix, or if the bug is only in the master branch.
Examples:
- 5.1.2
- 5.1.3 (RC1)
-->
- master
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #6514: Fix traffic_portal audit issues and remove un-needed deps
Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #6514:
URL: https://github.com/apache/trafficcontrol/pull/6514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #6514: Fix traffic_portal audit issues and remove un-needed deps
Posted by GitBox <gi...@apache.org>.
shamrickus commented on a change in pull request #6514:
URL: https://github.com/apache/trafficcontrol/pull/6514#discussion_r789953950
##########
File path: traffic_portal/package.json
##########
@@ -50,12 +41,12 @@
"angular-route": "1.8.0",
"angular-sanitize": "1.8.0",
"angular-ui-bootstrap": "0.14.3",
- "bootstrap-sass": "3.3.6",
- "es5-shim": "4.5.6",
+ "bootstrap-sass": "3.4.1",
+ "es5-shim": "4.6.4",
Review comment:
Technically `browserify` should be handling this for us anyways so you're probably right, but it's required in `shared-libs.js` which means it could be being used somewhere in the app. Removing that is the kind of change that i think would be better done in a separate PR (probably whatever PR we update angular in since we're out of date a few minor versions). All of the packages I've removed in this PR are not referenced _anywhere_ (aside from the jshint stuff) outside of the package.json.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6514: Fix traffic_portal audit issues and remove un-needed deps
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #6514:
URL: https://github.com/apache/trafficcontrol/pull/6514#discussion_r790012175
##########
File path: traffic_portal/package.json
##########
@@ -50,12 +41,12 @@
"angular-route": "1.8.0",
"angular-sanitize": "1.8.0",
"angular-ui-bootstrap": "0.14.3",
- "bootstrap-sass": "3.3.6",
- "es5-shim": "4.5.6",
+ "bootstrap-sass": "3.4.1",
+ "es5-shim": "4.6.4",
"flot": "2.3.2",
- "font-awesome": "4.5.0",
+ "font-awesome": "4.7.0",
"jquery": "3.6.0",
"jquery.flot.tooltip": "0.9.0",
- "json3": "3.3.2"
+ "json3": "3.3.3"
Review comment:
This is also referenced somewhere like `es5-shim`, so it should also be removed in another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6514: Fix traffic_portal audit issues and remove un-needed deps
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #6514:
URL: https://github.com/apache/trafficcontrol/pull/6514#discussion_r789946317
##########
File path: traffic_portal/package.json
##########
@@ -50,12 +41,12 @@
"angular-route": "1.8.0",
"angular-sanitize": "1.8.0",
"angular-ui-bootstrap": "0.14.3",
- "bootstrap-sass": "3.3.6",
- "es5-shim": "4.5.6",
+ "bootstrap-sass": "3.4.1",
+ "es5-shim": "4.6.4",
"flot": "2.3.2",
- "font-awesome": "4.5.0",
+ "font-awesome": "4.7.0",
"jquery": "3.6.0",
"jquery.flot.tooltip": "0.9.0",
- "json3": "3.3.2"
+ "json3": "3.3.3"
Review comment:
The description for the `json3` package on `npm` starts (after a deprecation notice) with the words _"JSON 3 **was**..."_ (emphasis mine), which is never a good sign. Neither is:
No major browser version since 2010 has not had support for `JSON` in the global scope ([source](https://caniuse.com/?search=JSON)) - again, predating the existence of Traffic Portal
##########
File path: traffic_portal/package.json
##########
@@ -50,12 +41,12 @@
"angular-route": "1.8.0",
"angular-sanitize": "1.8.0",
"angular-ui-bootstrap": "0.14.3",
- "bootstrap-sass": "3.3.6",
- "es5-shim": "4.5.6",
+ "bootstrap-sass": "3.4.1",
+ "es5-shim": "4.6.4",
Review comment:
Do we really need a shim for ES5? The only browser we truly support is Chrome, which added full support for ES5 70 major versions ago - which is a full decade behind us now, which in fact predates the very existence of this project. All other major browsers have full compliance as well ([source](https://caniuse.com/?search=es5)) with the exception of Opera Mini, which has an issue with `parseInt`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org