[GitHub] gianm commented on a change in pull request #6186: Serde test for JdbcExtractionNamespace.

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #6186: Serde test for JdbcExtractionNamespace.
URL: https://github.com/apache/incubator-druid/pull/6186#discussion_r210954250
 
 

 ##########
 File path: common/src/main/java/io/druid/metadata/MetadataStorageConnectorConfig.java
 ##########
 @@ -59,6 +59,7 @@ public int getPort()
     return port;
   }
 
+  @JsonProperty
 
 Review comment:
   I think it's not fixing any production bug, since the `@JsonProperty` on the `connectURI` field will get used if this one on the getter isn't there. In production that field is always going to be set. So I think this is technically a bug but it only affects test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org