[GitHub] [airflow] dstandish commented on pull request #21806: Rename `dagrun_id` to `dag_run_id`

[GitBox <gi...@apache.org>]

dstandish commented on pull request #21806:
URL: https://github.com/apache/airflow/pull/21806#issuecomment-1050616716


   @ashb re
   
   > I think this is fine. Any user/developer-facing backcompat concerns?
   
   I think we're ok here.
   
   i think the only changes that could possibly cause an issue are these:
   
   airflow.api.common.mark_tasks.set_state (signature change, rename param `dag_run_id` to `run_id`)
   IN_MEMORY_RUN_ID (rename from IN_MEMORY_DAG_RUN_ID)
   DagRunNotBackfillDep (rename from DagrunIdDep)
   
   I think all of these can reasonably be considered internal.
   
   And as mentioned in the description above, there will remain API parameters `dag_run_id` which will refer to the dag run run_id.  But I think that's OK and sortof orthogonal to the addition of this dag run ID column.  If we ever need to expose the integer Id, we'd probably want to rename "dag_run_id" to "run_id" anyway, rather than having two params "dag_run_id" and "dagrun_id" coexisting together.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org