You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2017/04/20 17:49:09 UTC
Review Request 58583: Trying to upgrade HDF 2.0.2.0 to HDF 3.0.0.0
fails with NPE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58583/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-20811
https://issues.apache.org/jira/browse/AMBARI-20811
Repository: ambari
Description
-------
The following steps were followed.
1. Installed ambari 2.4.1.0
2. Installed HDF 2.0.2.0
3. Upgraded ambari to 2.5.0.3
4 Upgraded mpack to 3.0.0.0-169 is installed.
5. Ambari launches successfully and HDF 2.0.2.0 shows correctly
6. Registered and installed the new version 3.0.0.0-169
7. Click on express upgrade. Throws 500
Ambari-server has the following exception in the logs
{code:None}
11 Apr 2017 08:11:59,794 ERROR [ambari-client-thread-194] ContainerResponse:419 - The RuntimeException could not be mapped to a response, re-throwing to the HTTP container
java.lang.NullPointerException
at org.apache.ambari.server.state.stack.ConfigUpgradePack.merge(ConfigUpgradePack.java:124)
at org.apache.ambari.server.controller.internal.UpgradeResourceProvider$ConfigurationPackBuilder.build(UpgradeResourceProvider.java:1839)
at org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createUpgrade(UpgradeResourceProvider.java:812)
at org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:382)
at org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:350)
at org.apache.ambari.server.controller.internal.AbstractResourceProvider.invokeWithRetry(AbstractResourceProvider.java:455)
at org.apache.ambari.server.controller.internal.AbstractResourceProvider.createResources(AbstractResourceProvider.java:278)
at org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createResources(UpgradeResourceProvider.java:350)
at org.apache.ambari.server.controller.internal.ClusterControllerImpl.createResources(ClusterControllerImpl.java:298)
at org.apache.ambari.server.api.services.persistence.PersistenceManagerImpl.create(PersistenceManagerImpl.java:97)
at org.apache.ambari.server.api.handlers.CreateHandler.persist(CreateHandler.java:37)
at org.apache.ambari.server.api.handlers.BaseManagementHandler.handleRequest(BaseManagementHandler.java:73)
at org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:144)
at org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:126)
at org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:90)
at org.apache.ambari.server.api.services.UpgradeService.createUpgrade(UpgradeService.java:58)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
{code}
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java daa9014162
Diff: https://reviews.apache.org/r/58583/diff/1/
Testing
-------
mvn clean test
Thanks,
Dmitro Lisnichenko
Re: Review Request 58583: Trying to upgrade HDF 2.0.2.0 to HDF
3.0.0.0 fails with NPE
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On April 20, 2017, 9:51 p.m., Jonathan Hurley wrote:
> > Can we write a simple unit test to verify that on a stack which has no config pack, one gets created?
done
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58583/#review172537
-----------------------------------------------------------
On April 21, 2017, 3:25 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58583/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 3:25 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-20811
> https://issues.apache.org/jira/browse/AMBARI-20811
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The following steps were followed.
> 1. Installed ambari 2.4.1.0
> 2. Installed HDF 2.0.2.0
> 3. Upgraded ambari to 2.5.0.3
> 4 Upgraded mpack to 3.0.0.0-169 is installed.
> 5. Ambari launches successfully and HDF 2.0.2.0 shows correctly
> 6. Registered and installed the new version 3.0.0.0-169
> 7. Click on express upgrade. Throws 500
>
> Ambari-server has the following exception in the logs
> {code:None}
> 11 Apr 2017 08:11:59,794 ERROR [ambari-client-thread-194] ContainerResponse:419 - The RuntimeException could not be mapped to a response, re-throwing to the HTTP container
> java.lang.NullPointerException
> at org.apache.ambari.server.state.stack.ConfigUpgradePack.merge(ConfigUpgradePack.java:124)
> at org.apache.ambari.server.controller.internal.UpgradeResourceProvider$ConfigurationPackBuilder.build(UpgradeResourceProvider.java:1839)
> at org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createUpgrade(UpgradeResourceProvider.java:812)
> at org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:382)
> at org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:350)
> at org.apache.ambari.server.controller.internal.AbstractResourceProvider.invokeWithRetry(AbstractResourceProvider.java:455)
> at org.apache.ambari.server.controller.internal.AbstractResourceProvider.createResources(AbstractResourceProvider.java:278)
> at org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createResources(UpgradeResourceProvider.java:350)
> at org.apache.ambari.server.controller.internal.ClusterControllerImpl.createResources(ClusterControllerImpl.java:298)
> at org.apache.ambari.server.api.services.persistence.PersistenceManagerImpl.create(PersistenceManagerImpl.java:97)
> at org.apache.ambari.server.api.handlers.CreateHandler.persist(CreateHandler.java:37)
> at org.apache.ambari.server.api.handlers.BaseManagementHandler.handleRequest(BaseManagementHandler.java:73)
> at org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:144)
> at org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:126)
> at org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:90)
> at org.apache.ambari.server.api.services.UpgradeService.createUpgrade(UpgradeService.java:58)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java daa9014162
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java 0234d797c8
>
>
> Diff: https://reviews.apache.org/r/58583/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 58583: Trying to upgrade HDF 2.0.2.0 to HDF
3.0.0.0 fails with NPE
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58583/#review172537
-----------------------------------------------------------
Ship it!
Can we write a simple unit test to verify that on a stack which has no config pack, one gets created?
- Jonathan Hurley
On April 20, 2017, 1:49 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58583/
> -----------------------------------------------------------
>
> (Updated April 20, 2017, 1:49 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-20811
> https://issues.apache.org/jira/browse/AMBARI-20811
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The following steps were followed.
> 1. Installed ambari 2.4.1.0
> 2. Installed HDF 2.0.2.0
> 3. Upgraded ambari to 2.5.0.3
> 4 Upgraded mpack to 3.0.0.0-169 is installed.
> 5. Ambari launches successfully and HDF 2.0.2.0 shows correctly
> 6. Registered and installed the new version 3.0.0.0-169
> 7. Click on express upgrade. Throws 500
>
> Ambari-server has the following exception in the logs
> {code:None}
> 11 Apr 2017 08:11:59,794 ERROR [ambari-client-thread-194] ContainerResponse:419 - The RuntimeException could not be mapped to a response, re-throwing to the HTTP container
> java.lang.NullPointerException
> at org.apache.ambari.server.state.stack.ConfigUpgradePack.merge(ConfigUpgradePack.java:124)
> at org.apache.ambari.server.controller.internal.UpgradeResourceProvider$ConfigurationPackBuilder.build(UpgradeResourceProvider.java:1839)
> at org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createUpgrade(UpgradeResourceProvider.java:812)
> at org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:382)
> at org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:350)
> at org.apache.ambari.server.controller.internal.AbstractResourceProvider.invokeWithRetry(AbstractResourceProvider.java:455)
> at org.apache.ambari.server.controller.internal.AbstractResourceProvider.createResources(AbstractResourceProvider.java:278)
> at org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createResources(UpgradeResourceProvider.java:350)
> at org.apache.ambari.server.controller.internal.ClusterControllerImpl.createResources(ClusterControllerImpl.java:298)
> at org.apache.ambari.server.api.services.persistence.PersistenceManagerImpl.create(PersistenceManagerImpl.java:97)
> at org.apache.ambari.server.api.handlers.CreateHandler.persist(CreateHandler.java:37)
> at org.apache.ambari.server.api.handlers.BaseManagementHandler.handleRequest(BaseManagementHandler.java:73)
> at org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:144)
> at org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:126)
> at org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:90)
> at org.apache.ambari.server.api.services.UpgradeService.createUpgrade(UpgradeService.java:58)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java daa9014162
>
>
> Diff: https://reviews.apache.org/r/58583/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 58583: Trying to upgrade HDF 2.0.2.0 to HDF
3.0.0.0 fails with NPE
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58583/#review172651
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On April 21, 2017, 8:25 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58583/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 8:25 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-20811
> https://issues.apache.org/jira/browse/AMBARI-20811
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The following steps were followed.
> 1. Installed ambari 2.4.1.0
> 2. Installed HDF 2.0.2.0
> 3. Upgraded ambari to 2.5.0.3
> 4 Upgraded mpack to 3.0.0.0-169 is installed.
> 5. Ambari launches successfully and HDF 2.0.2.0 shows correctly
> 6. Registered and installed the new version 3.0.0.0-169
> 7. Click on express upgrade. Throws 500
>
> Ambari-server has the following exception in the logs
> {code:None}
> 11 Apr 2017 08:11:59,794 ERROR [ambari-client-thread-194] ContainerResponse:419 - The RuntimeException could not be mapped to a response, re-throwing to the HTTP container
> java.lang.NullPointerException
> at org.apache.ambari.server.state.stack.ConfigUpgradePack.merge(ConfigUpgradePack.java:124)
> at org.apache.ambari.server.controller.internal.UpgradeResourceProvider$ConfigurationPackBuilder.build(UpgradeResourceProvider.java:1839)
> at org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createUpgrade(UpgradeResourceProvider.java:812)
> at org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:382)
> at org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:350)
> at org.apache.ambari.server.controller.internal.AbstractResourceProvider.invokeWithRetry(AbstractResourceProvider.java:455)
> at org.apache.ambari.server.controller.internal.AbstractResourceProvider.createResources(AbstractResourceProvider.java:278)
> at org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createResources(UpgradeResourceProvider.java:350)
> at org.apache.ambari.server.controller.internal.ClusterControllerImpl.createResources(ClusterControllerImpl.java:298)
> at org.apache.ambari.server.api.services.persistence.PersistenceManagerImpl.create(PersistenceManagerImpl.java:97)
> at org.apache.ambari.server.api.handlers.CreateHandler.persist(CreateHandler.java:37)
> at org.apache.ambari.server.api.handlers.BaseManagementHandler.handleRequest(BaseManagementHandler.java:73)
> at org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:144)
> at org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:126)
> at org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:90)
> at org.apache.ambari.server.api.services.UpgradeService.createUpgrade(UpgradeService.java:58)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java daa9014162
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java 0234d797c8
>
>
> Diff: https://reviews.apache.org/r/58583/diff/2/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 58583: Trying to upgrade HDF 2.0.2.0 to HDF
3.0.0.0 fails with NPE
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58583/
-----------------------------------------------------------
(Updated April 21, 2017, 3:25 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
Added a test
Bugs: AMBARI-20811
https://issues.apache.org/jira/browse/AMBARI-20811
Repository: ambari
Description
-------
The following steps were followed.
1. Installed ambari 2.4.1.0
2. Installed HDF 2.0.2.0
3. Upgraded ambari to 2.5.0.3
4 Upgraded mpack to 3.0.0.0-169 is installed.
5. Ambari launches successfully and HDF 2.0.2.0 shows correctly
6. Registered and installed the new version 3.0.0.0-169
7. Click on express upgrade. Throws 500
Ambari-server has the following exception in the logs
{code:None}
11 Apr 2017 08:11:59,794 ERROR [ambari-client-thread-194] ContainerResponse:419 - The RuntimeException could not be mapped to a response, re-throwing to the HTTP container
java.lang.NullPointerException
at org.apache.ambari.server.state.stack.ConfigUpgradePack.merge(ConfigUpgradePack.java:124)
at org.apache.ambari.server.controller.internal.UpgradeResourceProvider$ConfigurationPackBuilder.build(UpgradeResourceProvider.java:1839)
at org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createUpgrade(UpgradeResourceProvider.java:812)
at org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:382)
at org.apache.ambari.server.controller.internal.UpgradeResourceProvider$1.invoke(UpgradeResourceProvider.java:350)
at org.apache.ambari.server.controller.internal.AbstractResourceProvider.invokeWithRetry(AbstractResourceProvider.java:455)
at org.apache.ambari.server.controller.internal.AbstractResourceProvider.createResources(AbstractResourceProvider.java:278)
at org.apache.ambari.server.controller.internal.UpgradeResourceProvider.createResources(UpgradeResourceProvider.java:350)
at org.apache.ambari.server.controller.internal.ClusterControllerImpl.createResources(ClusterControllerImpl.java:298)
at org.apache.ambari.server.api.services.persistence.PersistenceManagerImpl.create(PersistenceManagerImpl.java:97)
at org.apache.ambari.server.api.handlers.CreateHandler.persist(CreateHandler.java:37)
at org.apache.ambari.server.api.handlers.BaseManagementHandler.handleRequest(BaseManagementHandler.java:73)
at org.apache.ambari.server.api.services.BaseRequest.process(BaseRequest.java:144)
at org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:126)
at org.apache.ambari.server.api.services.BaseService.handleRequest(BaseService.java:90)
at org.apache.ambari.server.api.services.UpgradeService.createUpgrade(UpgradeService.java:58)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
{code}
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java daa9014162
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java 0234d797c8
Diff: https://reviews.apache.org/r/58583/diff/2/
Changes: https://reviews.apache.org/r/58583/diff/1-2/
Testing
-------
mvn clean test
Thanks,
Dmitro Lisnichenko