You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/02/05 01:12:13 UTC

[GitHub] [incubator-gobblin] jack-moseley commented on a change in pull request #3220: [GOBBLIN-1380] Add retention to failed dag state store

jack-moseley commented on a change in pull request #3220:
URL: https://github.com/apache/incubator-gobblin/pull/3220#discussion_r570653519



##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -1144,6 +1154,15 @@ private void cleanUp() {
       for (String dagId: dagIdstoClean) {
         cleanUpDag(dagId);
       }
+
+      for (Iterator<Map.Entry<String, Dag<JobExecutionPlan>>> iter = this.failedDags.entrySet().iterator(); iter.hasNext();) {

Review comment:
       Good point, moved it to a separate thread for retention that runs every 60 mins by default.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org