[GitHub] [ignite-3] isapego commented on a diff in pull request #1935: IGNITE-19099 Java client: Add basic authentication support

["isapego (via GitHub)" <gi...@apache.org>]

isapego commented on code in PR #1935:
URL: https://github.com/apache/ignite-3/pull/1935#discussion_r1165254973


##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -321,9 +324,26 @@ private void handshake(ChannelHandlerContext ctx, ClientMessageUnpacker unpacker
         }
     }
 
-    private AuthenticationRequest<?, ?> createAuthenticationRequest(Map<HandshakeExtension, Object> extensions) {
-        return new UsernamePasswordRequest((String) extensions.get(HandshakeExtension.USERNAME),
-                (String) extensions.get(HandshakeExtension.PASSWORD));
+    private UserDetails authenticate(Map<HandshakeExtension, Object> extensions) {
+        AuthenticationRequest<?, ?> authenticationRequest = createAuthenticationRequest(extensions);
+
+        return authenticationManager.authenticate(authenticationRequest);
+    }
+
+    private static AuthenticationRequest<?, ?> createAuthenticationRequest(Map<HandshakeExtension, Object> extensions) {
+        Object authnType = extensions.get(HandshakeExtension.AUTHENTICATION_TYPE);
+
+        if (authnType == null) {
+            return new AnonymousRequest();
+        }
+
+        if (authnType.equals("basic")) {

Review Comment:
   Probably, need to move `"basic"` to some constant.



##########
modules/client/src/main/java/org/apache/ignite/client/IgniteClientAuthenticator.java:
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.client;
+
+/**
+ * Ignite client authenticator.
+ */

Review Comment:
   Lets add that it is used by a client to get credentials during authentication on a server node.



##########
modules/client/src/main/java/org/apache/ignite/client/BasicAuthenticator.java:
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.client;
+
+/**
+ * Basic authenticator.
+ */

Review Comment:
   Probably, should add what it means (single user, username + password transferred as a plain text). Probably, advice using it only for testing purposes or with TLS enabled?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org