You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2015/09/26 14:33:34 UTC
[GitHub] flink pull request: [FLINK-2769] [dashboard] Remove hard coded job...
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1185
[FLINK-2769] [dashboard] Remove hard coded job server URL
Removes the hard coded job server URL for the client scripts. This was preventing the web server port configuration to be picked up by the client.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink dashboard_port-2769
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1185.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1185
----
commit 118850ae95de9830705ad6b284967c964ea60674
Author: Ufuk Celebi <uc...@apache.org>
Date: 2015-09-26T12:12:20Z
[FLINK-2769] [dashboard] Remove hard coded job server URL
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2769] [dashboard] Remove hard coded job...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1185#issuecomment-143687678
+1
I built it and ran it on a custom port, data seems to be displayed correctly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2769] [dashboard] Remove hard coded job...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1185#issuecomment-143713277
+1, looks good.
I think the ports / URLs were in there, because originally we had two backend servers running (the old one and the new one) while gradually transitioning requests and adding more REST requests. For a time, the frontend connected to two different backends and did some tunneling/proxy magic to get around XSS restrictions...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2769] [dashboard] Remove hard coded job...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1185#issuecomment-143433645
Remember to assign the JIRA to yourself ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2769] [dashboard] Remove hard coded job...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1185#issuecomment-144012726
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2769] [dashboard] Remove hard coded job...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1185
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---