[GitHub] [flink-web] dannycranmer commented on a diff in pull request #673: Fix the search bar on Flink website

["dannycranmer (via GitHub)" <gi...@apache.org>]

dannycranmer commented on code in PR #673:
URL: https://github.com/apache/flink-web/pull/673#discussion_r1317235927


##########
docs/assets/search-data.js:
##########
@@ -36,15 +36,20 @@
 
   {{- $pages := where .Site.Pages "Kind" "in" (slice "page" "section") -}}
   {{- $pages = where $pages "Params.booksearchexclude" "!=" true -}}
-  {{- $pages = where $pages "Content" "not in" (slice nil "") -}}

Review Comment:
   @MartijnVisser I could not work out how to get this filter fixed. I tried a bunch of things, including inverting the logic from `not in` to `in`, and simplifying to `(slice nil)`/`(slice "")`.  Could not get any results. I have refactored to a non-ideal loop with filter using a counter to generate the index. It works..... but it is not nice :D 
   
   Any idea?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org