You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2025/11/13 22:43:01 UTC

[jira] [Commented] (HADOOP-19569) S3A: stream write/close fails badly once FS is closed

    [ https://issues.apache.org/jira/browse/HADOOP-19569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18038179#comment-18038179 ] 

ASF GitHub Bot commented on HADOOP-19569:
-----------------------------------------

hadoop-yetus commented on PR #7700:
URL: https://github.com/apache/hadoop/pull/7700#issuecomment-3530024137

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |  21m 35s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to include 17 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   7m 53s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  36m 15s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  18m 52s |  |  trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  compile  |  20m  0s |  |  trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  checkstyle  |   3m 47s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |   3m  0s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |   2m 12s |  |  trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javadoc  |   2m  9s |  |  trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04  |
   | -1 :x: |  spotbugs  |   3m  8s | [/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7700/13/artifact/out/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html) |  hadoop-common-project/hadoop-common in trunk has 448 extant spotbugs warnings.  |
   | -1 :x: |  spotbugs  |   1m 39s | [/branch-spotbugs-hadoop-tools_hadoop-aws-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7700/13/artifact/out/branch-spotbugs-hadoop-tools_hadoop-aws-warnings.html) |  hadoop-tools/hadoop-aws in trunk has 188 extant spotbugs warnings.  |
   | +1 :green_heart: |  shadedclient  |  32m  7s |  |  branch has no errors when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 32s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   1m 55s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  16m 30s |  |  the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |  16m 30s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  17m 41s |  |  the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04  |
   | +1 :green_heart: |  javac  |  17m 41s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks issues.  |
   | +1 :green_heart: |  checkstyle  |   3m 38s |  |  root: The patch generated 0 new + 13 unchanged - 5 fixed = 13 total (was 18)  |
   | +1 :green_heart: |  mvnsite  |   2m 57s |  |  the patch passed  |
   | -1 :x: |  javadoc  |   0m 51s | [/results-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-21.0.7+6-Ubuntu-0ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7700/13/artifact/out/results-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-21.0.7+6-Ubuntu-0ubuntu120.04.txt) |  hadoop-tools_hadoop-aws-jdkUbuntu-21.0.7+6-Ubuntu-0ubuntu120.04 with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 generated 2 new + 926 unchanged - 0 fixed = 928 total (was 926)  |
   | -1 :x: |  javadoc  |   0m 51s | [/results-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-17.0.15+6-Ubuntu-0ubuntu120.04.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7700/13/artifact/out/results-javadoc-javadoc-hadoop-tools_hadoop-aws-jdkUbuntu-17.0.15+6-Ubuntu-0ubuntu120.04.txt) |  hadoop-tools_hadoop-aws-jdkUbuntu-17.0.15+6-Ubuntu-0ubuntu120.04 with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 generated 2 new + 848 unchanged - 0 fixed = 850 total (was 848)  |
   | -1 :x: |  spotbugs  |   1m 53s | [/new-spotbugs-hadoop-tools_hadoop-aws.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7700/13/artifact/out/new-spotbugs-hadoop-tools_hadoop-aws.html) |  hadoop-tools/hadoop-aws generated 7 new + 186 unchanged - 2 fixed = 193 total (was 188)  |
   | +1 :green_heart: |  shadedclient  |  32m 32s |  |  patch has no errors when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | -1 :x: |  unit  |  22m 43s | [/patch-unit-hadoop-common-project_hadoop-common.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7700/13/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt) |  hadoop-common in the patch passed.  |
   | +1 :green_heart: |  unit  |   4m 40s |  |  hadoop-aws in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m  3s |  |  The patch does not generate ASF License warnings.  |
   |  |   | 270m 42s |  |  |
   
   
   | Reason | Tests |
   |-------:|:------|
   | SpotBugs | module:hadoop-tools/hadoop-aws |
   |  |  org.apache.hadoop.fs.s3a.S3AFileSystem.getStore() may expose internal representation by returning S3AFileSystem.store  At S3AFileSystem.java:by returning S3AFileSystem.store  At S3AFileSystem.java:[line 1363] |
   |  |  org.apache.hadoop.fs.s3a.impl.S3AStoreImpl.getInstrumentation() may expose internal representation by returning S3AStoreImpl.instrumentation  At S3AStoreImpl.java:by returning S3AStoreImpl.instrumentation  At S3AStoreImpl.java:[line 436] |
   |  |  org.apache.hadoop.fs.s3a.impl.write.StoreWriterService.bind(S3AStore, ClientManager, IORateLimiting) may expose internal representation by storing an externally mutable object into StoreWriterService.store  At StoreWriterService.java:internal representation by storing an externally mutable object into StoreWriterService.store  At StoreWriterService.java:[line 150] |
   |  |  new org.apache.hadoop.fs.s3a.impl.write.StoreWriterService$UploadIterator(StoreWriterService, StoreContext, int, String) may expose internal representation by storing an externally mutable object into StoreWriterService$UploadIterator.this$0  At StoreWriterService.java:may expose internal representation by storing an externally mutable object into StoreWriterService$UploadIterator.this$0  At StoreWriterService.java:[line 584] |
   |  |  new org.apache.hadoop.fs.s3a.impl.write.WriteOperationHelper(AuditSpanSource, AuditSpan, WriteOperationHelperCallbacks) may expose internal representation by storing an externally mutable object into WriteOperationHelper.auditSpan  At WriteOperationHelper.java:expose internal representation by storing an externally mutable object into WriteOperationHelper.auditSpan  At WriteOperationHelper.java:[line 148] |
   |  |  new org.apache.hadoop.fs.s3a.impl.write.WriteOperationHelper(AuditSpanSource, AuditSpan, WriteOperationHelperCallbacks) may expose internal representation by storing an externally mutable object into WriteOperationHelper.callbacks  At WriteOperationHelper.java:expose internal representation by storing an externally mutable object into WriteOperationHelper.callbacks  At WriteOperationHelper.java:[line 150] |
   |  |  new org.apache.hadoop.fs.s3a.impl.write.WriteOperationHelperCallbacksImpl(S3AStore) may expose internal representation by storing an externally mutable object into WriteOperationHelperCallbacksImpl.store  At WriteOperationHelperCallbacksImpl.java:representation by storing an externally mutable object into WriteOperationHelperCallbacksImpl.store  At WriteOperationHelperCallbacksImpl.java:[line 67] |
   | Failed junit tests | hadoop.security.ssl.TestDelegatingSSLSocketFactory |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7700/13/artifact/out/Dockerfile |
   | GITHUB PR | https://github.com/apache/hadoop/pull/7700 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
   | uname | Linux 83313e19144f 5.15.0-160-generic #170-Ubuntu SMP Wed Oct 1 10:06:56 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 4a8057872a2bb7f7f017a84806a26dc32d8637e3 |
   | Default Java | Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 |
   | Multi-JDK versions | /usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 |
   |  Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7700/13/testReport/ |
   | Max. process+thread count | 1294 (vs. ulimit of 5500) |
   | modules | C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: . |
   | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7700/13/console |
   | versions | git=2.25.1 maven=3.9.11 spotbugs=4.9.7 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> S3A: stream write/close fails badly once FS is closed
> -----------------------------------------------------
>
>                 Key: HADOOP-19569
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19569
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/s3
>    Affects Versions: 3.5.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>
> when closing a process during a large upload, and NPE is triggered in the abort call. This is because the S3 client has already been released.
> {code}
> java.lang.NullPointerException
>         at org.apache.hadoop.fs.s3a.S3AFileSystem.lambda$abortMultipartUpload$41(S3AFileSystem.java:5337)
>         at org.apache.hadoop.fs.statistics.impl.IOStatisticsBinding.invokeTrackingDuration(IOStatisticsBinding.java:547)
>         at org.apache.hadoop.fs.statistics.impl.IOStatisticsBinding.lambda$trackDurationOfOperation$5(IOStatisticsBinding.java:528)
>         at org.apache.hadoop.fs.statistics.impl.IOStatisticsBinding.trackDuration(IOStatisticsBinding.java:449)
>         at org.apache.hadoop.fs.s3a.S3AFileSystem.abortMultipartUpload(S3AFileSystem.java:5336)
>         at org.apache.hadoop.fs.s3a.WriteOperationHelper.lambda$abortMultipartUpload$4(WriteOperationHelper.java:392)
> {code}
> * close() in small writes also fails, just with a different exception
> * and on some large writes, the output stream hangs as it awaits the end of the queued writes. This is a problem inside the semaphore executor



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org