You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by Jim Marino <jm...@myromatours.com> on 2006/07/28 20:39:00 UTC
another gentle reminder: -Psourcecheck
When doing a check-in or submitting a patch, please remember to run
mvn with -Psourcecheck to ensure checkstyle and PMD pass. I've
forgotten myself a couple of times but I have noticed the build has
failed several times recently due to PMD errors.
Thanks,
Jim
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: another gentle reminder: -Psourcecheck
Posted by Jim Marino <jm...@myromatours.com>.
Yea we should. I'll see what we can do. I should caveat this that it
applies only to Java SCA but others may want to consider it for DAS
and SDO (you may want to customize it since the codebases use
different formatting guidelines). While codestyle and PMD can be a
bit dictatorial at times, I have found them helpful at catching silly
mistakes and keeping the code formatting consistent.
Jim
On Jul 28, 2006, at 12:52 PM, Brent Daniel wrote:
> Is this information on the wiki or main web site anywhere? I wasn't
> aware of it. Maybe we should have a "Guidelines for patch submission"
> page on the wiki that covers Tuscany specific expectations?
>
> Brent
>
> On 7/28/06, Jim Marino <jm...@myromatours.com> wrote:
>> When doing a check-in or submitting a patch, please remember to run
>> mvn with -Psourcecheck to ensure checkstyle and PMD pass. I've
>> forgotten myself a couple of times but I have noticed the build has
>> failed several times recently due to PMD errors.
>>
>> Thanks,
>> Jim
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: another gentle reminder: -Psourcecheck
Posted by Jim Marino <jm...@myromatours.com>.
There have been a number of messages to the list related to this but
as Brent suggested this should go into the coding standards.
Unfortunately I don't use Eclipse but I'm not aware of any
significant problems with it and the rules enforced by Checkstyle or
PMD. Are you having a particular problem on Eclipse?
Jim
On Jul 29, 2006, at 1:40 AM, ant elder wrote:
> I wasn't aware of it either Brent. The last mention of it I can
> remember was
> this one:
>
> http://mail-archives.apache.org/mod_mbox/ws-tuscany-dev/200606.mbox/
> %3c997a3eab0606260945t2d5644a9wc4992479b6345d43@mail.gmail.com%3e
>
> Has there been subsequent discussion on this that I've missed, has the
> compatibility with eclipse formatting been resolved?
>
> ...ant
>
> On 7/28/06, Brent Daniel <br...@gmail.com> wrote:
>>
>> Is this information on the wiki or main web site anywhere? I wasn't
>> aware of it. Maybe we should have a "Guidelines for patch submission"
>> page on the wiki that covers Tuscany specific expectations?
>>
>> Brent
>>
>> On 7/28/06, Jim Marino <jm...@myromatours.com> wrote:
>> > When doing a check-in or submitting a patch, please remember to run
>> > mvn with -Psourcecheck to ensure checkstyle and PMD pass. I've
>> > forgotten myself a couple of times but I have noticed the build has
>> > failed several times recently due to PMD errors.
>> >
>> > Thanks,
>> > Jim
>> >
>> >
>> >
>> ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>> > For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>> >
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: another gentle reminder: -Psourcecheck
Posted by ant elder <an...@gmail.com>.
I wasn't aware of it either Brent. The last mention of it I can remember was
this one:
http://mail-archives.apache.org/mod_mbox/ws-tuscany-dev/200606.mbox/%3c997a3eab0606260945t2d5644a9wc4992479b6345d43@mail.gmail.com%3e
Has there been subsequent discussion on this that I've missed, has the
compatibility with eclipse formatting been resolved?
...ant
On 7/28/06, Brent Daniel <br...@gmail.com> wrote:
>
> Is this information on the wiki or main web site anywhere? I wasn't
> aware of it. Maybe we should have a "Guidelines for patch submission"
> page on the wiki that covers Tuscany specific expectations?
>
> Brent
>
> On 7/28/06, Jim Marino <jm...@myromatours.com> wrote:
> > When doing a check-in or submitting a patch, please remember to run
> > mvn with -Psourcecheck to ensure checkstyle and PMD pass. I've
> > forgotten myself a couple of times but I have noticed the build has
> > failed several times recently due to PMD errors.
> >
> > Thanks,
> > Jim
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: tuscany-dev-help@ws.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
>
Re: another gentle reminder: -Psourcecheck
Posted by Brent Daniel <br...@gmail.com>.
Is this information on the wiki or main web site anywhere? I wasn't
aware of it. Maybe we should have a "Guidelines for patch submission"
page on the wiki that covers Tuscany specific expectations?
Brent
On 7/28/06, Jim Marino <jm...@myromatours.com> wrote:
> When doing a check-in or submitting a patch, please remember to run
> mvn with -Psourcecheck to ensure checkstyle and PMD pass. I've
> forgotten myself a couple of times but I have noticed the build has
> failed several times recently due to PMD errors.
>
> Thanks,
> Jim
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org