You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/08/30 08:29:06 UTC
[GitHub] [incubator-seatunnel] hk-lrzy opened a new pull request, #2563: [SeaTunnel]Simply seatunnel package pipeline.
hk-lrzy opened a new pull request, #2563:
URL: https://github.com/apache/incubator-seatunnel/pull/2563
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2563: [SeaTunnel]Simply seatunnel package pipeline.
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2563:
URL: https://github.com/apache/incubator-seatunnel/pull/2563#issuecomment-1231334604
hi, could you add the doc for this? https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/setup.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2563: [SeaTunnel]Simply seatunnel package pipeline.
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2563:
URL: https://github.com/apache/incubator-seatunnel/pull/2563#discussion_r958257672
##########
seatunnel-dist/pom.xml:
##########
@@ -57,6 +57,37 @@
<artifactId>seatunnel-connectors-flink-dist</artifactId>
<version>${project.version}</version>
</dependency>
+
+ <!-- seatunnel core dependencies -->
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-core-flink</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-core-flink-sql</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-core-spark</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-flink-starter</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-spark-starter</artifactId>
+ <version>${project.version}</version>
+ </dependency>
</dependencies>
Review Comment:
Have you tested this, I think you are missing `seatunnel-connectors-v2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hk-lrzy commented on a diff in pull request #2563: [SeaTunnel]Simply seatunnel package pipeline.
Posted by GitBox <gi...@apache.org>.
hk-lrzy commented on code in PR #2563:
URL: https://github.com/apache/incubator-seatunnel/pull/2563#discussion_r958262964
##########
seatunnel-dist/pom.xml:
##########
@@ -57,6 +57,37 @@
<artifactId>seatunnel-connectors-flink-dist</artifactId>
<version>${project.version}</version>
</dependency>
+
+ <!-- seatunnel core dependencies -->
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-core-flink</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-core-flink-sql</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-core-spark</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-flink-starter</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-spark-starter</artifactId>
+ <version>${project.version}</version>
+ </dependency>
</dependencies>
Review Comment:
<img width="612" alt="截屏2022-08-30 17 48 50" src="https://user-images.githubusercontent.com/14176134/187406315-0f5df947-d29a-449b-bc1a-5e698d907e69.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hk-lrzy commented on pull request #2563: [SeaTunnel]Simply seatunnel package pipeline.
Posted by GitBox <gi...@apache.org>.
hk-lrzy commented on PR #2563:
URL: https://github.com/apache/incubator-seatunnel/pull/2563#issuecomment-1231338521
> hi, could you add the doc for this? https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/setup.md
Sure, i will add it in next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #2563: [SeaTunnel]Simply seatunnel package pipeline.
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #2563:
URL: https://github.com/apache/incubator-seatunnel/pull/2563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hk-lrzy commented on pull request #2563: [SeaTunnel]Simply seatunnel package pipeline.
Posted by GitBox <gi...@apache.org>.
hk-lrzy commented on PR #2563:
URL: https://github.com/apache/incubator-seatunnel/pull/2563#issuecomment-1231374892
> > hi, could you add the doc for this? https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/setup.md
>
> Sure, i will add it in next commit.
I already modify the setup docs, plz take a look again, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hk-lrzy commented on a diff in pull request #2563: [SeaTunnel]Simply seatunnel package pipeline.
Posted by GitBox <gi...@apache.org>.
hk-lrzy commented on code in PR #2563:
URL: https://github.com/apache/incubator-seatunnel/pull/2563#discussion_r958262090
##########
seatunnel-dist/pom.xml:
##########
@@ -57,6 +57,37 @@
<artifactId>seatunnel-connectors-flink-dist</artifactId>
<version>${project.version}</version>
</dependency>
+
+ <!-- seatunnel core dependencies -->
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-core-flink</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-core-flink-sql</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-core-spark</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-flink-starter</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-spark-starter</artifactId>
+ <version>${project.version}</version>
+ </dependency>
</dependencies>
Review Comment:
i tested it, `seatunnel-connectors-v2` already contans in `seatunnel-connectors-v2-dist`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2563: [SeaTunnel]Simply seatunnel package pipeline.
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2563:
URL: https://github.com/apache/incubator-seatunnel/pull/2563#discussion_r958296750
##########
seatunnel-dist/pom.xml:
##########
@@ -57,6 +57,37 @@
<artifactId>seatunnel-connectors-flink-dist</artifactId>
<version>${project.version}</version>
</dependency>
+
+ <!-- seatunnel core dependencies -->
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-core-flink</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-core-flink-sql</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-core-spark</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-flink-starter</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>org.apache.seatunnel</groupId>
+ <artifactId>seatunnel-spark-starter</artifactId>
+ <version>${project.version}</version>
+ </dependency>
</dependencies>
Review Comment:
Ah,i ignored this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2563: [SeaTunnel]Simply seatunnel package pipeline.
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2563:
URL: https://github.com/apache/incubator-seatunnel/pull/2563#issuecomment-1231552811
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org