You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "laurentschoelens (via GitHub)" <gi...@apache.org> on 2023/03/14 10:37:08 UTC
[GitHub] [commons-lang] laurentschoelens opened a new pull request, #1038: LANG-1687 : Propose update from substringBetween doc and new method
laurentschoelens opened a new pull request, #1038:
URL: https://github.com/apache/commons-lang/pull/1038
Propose an update to documentation of substringBetween (treat LANG-1687) and add new method to have behaviour wanted by the user
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] laurentschoelens commented on pull request #1038: LANG-1687 : Propose update from substringBetween doc and new method
Posted by "laurentschoelens (via GitHub)" <gi...@apache.org>.
laurentschoelens commented on PR #1038:
URL: https://github.com/apache/commons-lang/pull/1038#issuecomment-1468008183
HI @garydgregory thanks for the review and comment.
Someone thought the stringBetween works like taking the substring between two string, with last argument taken as far as possible, and maybe there is some use-cases, and the documentation is not clear on that.
If not adding the new function, maybe updating the documentation to make it clear what it does should be enough :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] laurentschoelens commented on pull request #1038: LANG-1687 : Propose update from substringBetween doc and new method
Posted by "laurentschoelens (via GitHub)" <gi...@apache.org>.
laurentschoelens commented on PR #1038:
URL: https://github.com/apache/commons-lang/pull/1038#issuecomment-1468505709
> > @garydgregory : got an exemple for you of usage `5 * ((6 * 7 + 2) * 3)` Actual method will return `(6 * 7 + 2` where we would like to have `(6 * 7 + 2) * 3` with params `"(", ")"`
>
> Hello @laurentschoelens I hope that's a random made up example because it's not a good one ;-) Expression parsing should not be hand-coded IMO, that's what Antlr and JavaCC are for...
Yes that is hand made but it's only to point that there could be some usage 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] codecov-commenter commented on pull request #1038: LANG-1687 : Propose update from substringBetween doc and new method
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1038:
URL: https://github.com/apache/commons-lang/pull/1038#issuecomment-1468056026
## [Codecov](https://codecov.io/gh/apache/commons-lang/pull/1038?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1038](https://codecov.io/gh/apache/commons-lang/pull/1038?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a7b485) into [master](https://codecov.io/gh/apache/commons-lang/commit/4d7e6ffac8f34ea6554078054c866ea76502f8ed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4d7e6ff) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #1038 +/- ##
============================================
+ Coverage 92.06% 92.08% +0.01%
- Complexity 7482 7486 +4
============================================
Files 194 194
Lines 15721 15727 +6
Branches 2897 2899 +2
============================================
+ Hits 14474 14482 +8
+ Misses 674 673 -1
+ Partials 573 572 -1
```
| [Impacted Files](https://codecov.io/gh/apache/commons-lang/pull/1038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ain/java/org/apache/commons/lang3/StringUtils.java](https://codecov.io/gh/apache/commons-lang/pull/1038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvU3RyaW5nVXRpbHMuamF2YQ==) | `98.86% <100.00%> (+<0.01%)` | :arrow_up: |
... and [1 file with indirect coverage changes](https://codecov.io/gh/apache/commons-lang/pull/1038/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] laurentschoelens commented on pull request #1038: LANG-1687 : Propose update from substringBetween doc and new method
Posted by "laurentschoelens (via GitHub)" <gi...@apache.org>.
laurentschoelens commented on PR #1038:
URL: https://github.com/apache/commons-lang/pull/1038#issuecomment-1468443524
@garydgregory : got an exemple for you of usage
`5 * ((6 * 7 + 2) * 3)`
Actual method will return `(6 * 7 + 2` where we would lire to have `(6 * 7 + 2) * 3` with params `"("), ")"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] laurentschoelens commented on pull request #1038: LANG-1687 : Propose update from substringBetween doc and new method
Posted by "laurentschoelens (via GitHub)" <gi...@apache.org>.
laurentschoelens commented on PR #1038:
URL: https://github.com/apache/commons-lang/pull/1038#issuecomment-1468077988
seen build failed due to checkstyle violation (not having checkstyle activated on my IDE), added a fix for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #1038: LANG-1687 : Propose update from substringBetween doc and new method
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1038:
URL: https://github.com/apache/commons-lang/pull/1038#issuecomment-1468002870
I am -1 for this new feature which feels like a super niche use case which overcomplicates the code base. I'm curious to hear what others think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #1038: LANG-1687 : Propose update from substringBetween doc and new method
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1038:
URL: https://github.com/apache/commons-lang/pull/1038#issuecomment-1468500322
> @garydgregory : got an exemple for you of usage `5 * ((6 * 7 + 2) * 3)` Actual method will return `(6 * 7 + 2` where we would like to have `(6 * 7 + 2) * 3` with params `"(", ")"`
Hello @laurentschoelens
I hope that's a random made up example because it's not a good one ;-) Expression parsing should not be hand-coded IMO, that's what Antlr and JavaCC are for...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org