You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mehul Parikh <me...@freestoneinfotech.com> on 2016/06/13 14:12:10 UTC

Review Request 48638: RANGER-1028 : Audit log not created for change of Tag based service name

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48638/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.


Bugs: RANGER-1028
    https://issues.apache.org/jira/browse/RANGER-1028


Repository: ranger


Description
-------

**Problem Statement ::**

1. Audit tab : No logs getting generated if we change.
  Tag based service name
  policy status
2. Users/Groups tab - Page remains in loading state when non admin user with user/group tab permission tries to hide another user.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java e897178 
  security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java cb4c16a 
  security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 042c239 
  security-admin/src/main/resources/conf.dist/security-applicationContext.xml 13ddb26 
  security-admin/src/main/webapp/scripts/views/reports/OperationDiffDetail.js d8db847 
  security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js a766705 
  security-admin/src/main/webapp/templates/common/ErrorView_tmpl.html e2f03b2 

Diff: https://reviews.apache.org/r/48638/diff/


Testing
-------

**Verified ::**
1. Logs are getting generated if user changes tag-service name or policy status

2. User with User-role(having permissions on User-Group tab) can not make change in visibility of the other user as message comes: "Operation denied. LoggedInUser=8 ,isn't permitted to perform the action."


Thanks,

Mehul Parikh


Re: Review Request 48638: RANGER-1028 : Audit log not created for change of Tag based service name

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48638/#review138153
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On June 13, 2016, 2:12 p.m., Mehul Parikh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48638/
> -----------------------------------------------------------
> 
> (Updated June 13, 2016, 2:12 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1028
>     https://issues.apache.org/jira/browse/RANGER-1028
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> **Problem Statement ::**
> 
> 1. Audit tab : No logs getting generated if we change.
>   Tag based service name
>   policy status
> 2. Users/Groups tab - Page remains in loading state when non admin user with user/group tab permission tries to hide another user.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java e897178 
>   security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthFailureHandler.java cb4c16a 
>   security-admin/src/main/java/org/apache/ranger/service/RangerPolicyService.java 042c239 
>   security-admin/src/main/resources/conf.dist/security-applicationContext.xml 13ddb26 
>   security-admin/src/main/webapp/scripts/views/reports/OperationDiffDetail.js d8db847 
>   security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js a766705 
>   security-admin/src/main/webapp/templates/common/ErrorView_tmpl.html e2f03b2 
> 
> Diff: https://reviews.apache.org/r/48638/diff/
> 
> 
> Testing
> -------
> 
> **Verified ::**
> 1. Logs are getting generated if user changes tag-service name or policy status
> 
> 2. User with User-role(having permissions on User-Group tab) can not make change in visibility of the other user as message comes: "Operation denied. LoggedInUser=8 ,isn't permitted to perform the action."
> 
> 
> Thanks,
> 
> Mehul Parikh
> 
>