You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Abhinav Dixit (Jira)" <ji...@apache.org> on 2024/11/17 16:15:00 UTC
[jira] [Updated] (KAFKA-18027) MINOR: Correct DelayedOperationPurgatory comment about operation completion
[ https://issues.apache.org/jira/browse/KAFKA-18027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Abhinav Dixit updated KAFKA-18027:
----------------------------------
Description:
In reference to comment [https://github.com/apache/kafka/pull/17739#discussion_r1844998612] ,the below comment seems inaccurate. Currently, we add a delayed operation to either all keys or none of the keys. Nevertheless, the property that onComplete() is only called once when the operation is not completed still holds. It would be useful to fix the comment.
{quote}In this case, the operation is considered completed and won't be added to the watch list of the remaining keys.
{quote}
was:
In reference to comment [https://github.com/apache/kafka/pull/17739#discussion_r1844998612] ,the comment
{quote}In this case, the operation is considered completed and won't be added to the watch list of the remaining keys.
{quote}
seems inaccurate. Currently, we add a delayed operation to either all keys or none of the keys. Nevertheless, the property that onComplete() is only called once when the operation is not completed still holds. It would be useful to fix the comment.
> MINOR: Correct DelayedOperationPurgatory comment about operation completion
> ---------------------------------------------------------------------------
>
> Key: KAFKA-18027
> URL: https://issues.apache.org/jira/browse/KAFKA-18027
> Project: Kafka
> Issue Type: Bug
> Reporter: Abhinav Dixit
> Assignee: Abhinav Dixit
> Priority: Major
>
> In reference to comment [https://github.com/apache/kafka/pull/17739#discussion_r1844998612] ,the below comment seems inaccurate. Currently, we add a delayed operation to either all keys or none of the keys. Nevertheless, the property that onComplete() is only called once when the operation is not completed still holds. It would be useful to fix the comment.
> {quote}In this case, the operation is considered completed and won't be added to the watch list of the remaining keys.
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)