You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/05 12:39:03 UTC
[GitHub] [nuttx] qinwei2004 opened a new pull request, #8032: fs/vfs: add missed truncate callback at timerfd file_operation
qinwei2004 opened a new pull request, #8032:
URL: https://github.com/apache/nuttx/pull/8032
Signed-off-by: qinwei1 <qi...@xiaomi.com>
## Summary
add missed truncate callback at timerfd file_operation
## Impact
None
## Testing
configure with CONFIG_TIMER_FD to compile with fs_timerfd.c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8032: fs/vfs: add missed truncate callback at timerfd file_operation
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8032:
URL: https://github.com/apache/nuttx/pull/8032#discussion_r1062450670
##########
fs/vfs/fs_timerfd.c:
##########
@@ -111,8 +111,12 @@ static const struct file_operations g_timerfd_fops =
NULL, /* write */
NULL, /* seek */
NULL, /* ioctl */
+ NULL, /* truncate */
#ifdef CONFIG_TIMER_FD_POLL
timerfd_poll /* poll */
+#else
Review Comment:
don't need else
##########
fs/vfs/fs_timerfd.c:
##########
@@ -111,8 +111,12 @@ static const struct file_operations g_timerfd_fops =
NULL, /* write */
NULL, /* seek */
NULL, /* ioctl */
+ NULL, /* truncate */
Review Comment:
need add another NULL for mmap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8032: fs/vfs: add missed truncate callback at timerfd file_operation
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #8032:
URL: https://github.com/apache/nuttx/pull/8032#discussion_r1063497892
##########
fs/vfs/fs_timerfd.c:
##########
@@ -111,6 +111,8 @@ static const struct file_operations g_timerfd_fops =
NULL, /* write */
NULL, /* seek */
NULL, /* ioctl */
+ NULL, /* truncate */
Review Comment:
@pkarashchenko Here https://github.com/apache/nuttx/pull/8053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8032: fs/vfs: add missed truncate callback at timerfd file_operation
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #8032:
URL: https://github.com/apache/nuttx/pull/8032#discussion_r1063246453
##########
fs/vfs/fs_timerfd.c:
##########
@@ -111,6 +111,8 @@ static const struct file_operations g_timerfd_fops =
NULL, /* write */
NULL, /* seek */
NULL, /* ioctl */
+ NULL, /* truncate */
Review Comment:
Please reorder comments. mmap before truncate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8032: fs/vfs: add missed truncate callback at timerfd file_operation
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #8032:
URL: https://github.com/apache/nuttx/pull/8032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org