You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2019/07/03 20:35:00 UTC
[jira] [Commented] (HIVE-21912) Implement
BlacklistingLlapMetricsListener
[ https://issues.apache.org/jira/browse/HIVE-21912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878150#comment-16878150 ]
Hive QA commented on HIVE-21912:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 34s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 0s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 34s{color} | {color:blue} common in master has 62 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 33s{color} | {color:blue} llap-common in master has 90 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 24s{color} | {color:blue} llap-client in master has 26 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 26s{color} | {color:blue} llap-tez in master has 17 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 44s{color} | {color:blue} llap-server in master has 83 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 6s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 27s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 21s{color} | {color:red} llap-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 21s{color} | {color:red} llap-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 21s{color} | {color:red} llap-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 10s{color} | {color:red} llap-common: The patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 9s{color} | {color:red} llap-client: The patch generated 1 new + 18 unchanged - 1 fixed = 19 total (was 19) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 11s{color} | {color:red} llap-tez: The patch generated 6 new + 4 unchanged - 0 fixed = 10 total (was 4) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 13s{color} | {color:red} llap-server: The patch generated 2 new + 0 unchanged - 7 fixed = 2 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 35s{color} | {color:red} llap-tez generated 1 new + 17 unchanged - 0 fixed = 18 total (was 17) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 17s{color} | {color:red} llap-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 26s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:llap-tez |
| | org.apache.hadoop.hive.llap.tezplugins.metrics.BlacklistingLlapMetricsListener.newClusterMetrics(Map) makes inefficient use of keySet iterator instead of entrySet iterator At BlacklistingLlapMetricsListener.java:keySet iterator instead of entrySet iterator At BlacklistingLlapMetricsListener.java:[line 106] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17836/dev-support/hive-personality.sh |
| git revision | master / 3f0935e |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-17836/yetus/patch-mvninstall-llap-server.txt |
| compile | http://104.198.109.242/logs//PreCommit-HIVE-Build-17836/yetus/patch-compile-llap-server.txt |
| javac | http://104.198.109.242/logs//PreCommit-HIVE-Build-17836/yetus/patch-compile-llap-server.txt |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17836/yetus/diff-checkstyle-llap-common.txt |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17836/yetus/diff-checkstyle-llap-client.txt |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17836/yetus/diff-checkstyle-llap-tez.txt |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17836/yetus/diff-checkstyle-llap-server.txt |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-17836/yetus/new-findbugs-llap-tez.html |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-17836/yetus/patch-findbugs-llap-server.txt |
| modules | C: common llap-common llap-client llap-tez llap-server U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17836/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Implement BlacklistingLlapMetricsListener
> -----------------------------------------
>
> Key: HIVE-21912
> URL: https://issues.apache.org/jira/browse/HIVE-21912
> Project: Hive
> Issue Type: Sub-task
> Components: llap, Tez
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21912.patch, HIVE-21912.wip-2.patch, HIVE-21912.wip.patch
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> We should implement a DaemonStatisticsHandler which:
> * If a node average response time is bigger than 150% (configurable) of the other nodes
> * If the other nodes has enough empty executors to handle the requests
> Then disables the limping node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)