You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/08/21 03:01:41 UTC
[GitHub] [spark] zhengruifeng commented on pull request #42579: [SPARK-44887][DOCS] Fix wildcard import `from pyspark.sql.functions import *` in `Quick Start` Examples
zhengruifeng commented on PR #42579:
URL: https://github.com/apache/spark/pull/42579#issuecomment-1685551050
there are two wildcard import under `docs`:
```
(spark_dev_310) ➜ spark git:(master) ag -i 'import \*' docs
docs/sql-ref-datatypes.md
117:from pyspark.sql.types import *
docs/quick-start.md
133:>>> from pyspark.sql.functions import *
(spark_dev_310) ➜ spark git:(master)
```
As to the `from pyspark.sql.types import *` in https://spark.apache.org/docs/latest/sql-ref-datatypes.html#data-types, I think we don't need to touch it, since there should not be any namespace conflicts as far as I know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org