You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Kevin Brown (JIRA)" <ji...@apache.org> on 2008/03/23 07:13:24 UTC
[jira] Created: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
---------------------------------------------------------------------------------------------------------
Key: SHINDIG-146
URL: https://issues.apache.org/jira/browse/SHINDIG-146
Project: Shindig
Issue Type: Improvement
Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
Reporter: Kevin Brown
Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
- Rename SyndicatorConfig classes to ContainerConfig
- Rename "syndicator" parameters / variables throughout the code base to "container"
- Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santiago Gala reassigned SHINDIG-146:
-------------------------------------
Assignee: Santiago Gala
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP), Sample container & Examples
> Reporter: Kevin Brown
> Assignee: Santiago Gala
> Attachments: SHINDIG-146-for-humans-2.patch, SHINDIG-146-for-humans-3.patch, SHINDIG-146-for-humans-squashed-2.patch, SHINDIG-146-for-humans-squashed-3.patch, SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed-2.patch, SHINDIG-146-for-robots-squashed-3.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586405#action_12586405 ]
Santiago Gala commented on SHINDIG-146:
---------------------------------------
Second version, including the wrong rename and a small number of things that I forgot.
http://github.com/sgala/apache-incubator-shindig/commits/synd-rename-2
The differences between both patch versions (readable if JIRA just supported monospaced fonts. Renames are in the summary above):
$ git diff --stat=100,90 -p -M origin/synd-rename synd-rename-2
java/gadgets/src/main/java/org/apache/shindig/gadgets/ContainerConfig.java | 8 +++---
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingTask.java | 2 +-
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpGadgetContext.java | 2 +-
javascript/container/gadgets.js | 4 +-
php/gadgets/src/{ConfiguratorConfig.php => ContainerConfig.php} | 0
php/gadgets/src/GadgetContext.php | 5 +--
6 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/java/gadgets/src/main/java/org/apache/shindig/gadgets/ContainerConfig.java b/java/gadgets/src/main/java/org/apache/shindig/gadgets/ContainerConfig.java
index 6f7ed68..e50f7c1 100644
--- a/java/gadgets/src/main/java/org/apache/shindig/gadgets/ContainerConfig.java
+++ b/java/gadgets/src/main/java/org/apache/shindig/gadgets/ContainerConfig.java
@@ -242,10 +242,10 @@ public class ContainerConfig {
try {
JSONObject contents = new JSONObject(json);
JSONArray containers = contents.getJSONArray(CONTAINER_KEY);
- JSONObject defaultSynd = config.get(DEFAULT_CONTAINER);
- if (defaultSynd == null) {
+ JSONObject defaultContainer = config.get(DEFAULT_CONTAINER);
+ if (defaultContainer == null) {
if (DEFAULT_CONTAINER.equals(containers.get(0))) {
- defaultSynd = contents;
+ defaultContainer = contents;
config.put(DEFAULT_CONTAINER, contents);
} else {
throw new GadgetException(GadgetException.Code.INVALID_CONFIG,
@@ -256,7 +256,7 @@ public class ContainerConfig {
// Copy the default object and produce a new one.
String container = containers.getString(i);
if (!DEFAULT_CONTAINER.equals(container)) {
- config.put(container, mergeObjects(defaultSynd, contents));
+ config.put(container, mergeObjects(defaultContainer, contents));
}
}
} catch (JSONException e) {
diff --git a/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingTask.java b/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingTask.java
index e19e4e1..f7d38b1 100644
--- a/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingTask.java
+++ b/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingTask.java
@@ -424,7 +424,7 @@ public class GadgetRenderingTask {
private boolean validateParent() {
String container = request.getParameter("container");
if (container == null) {
- // The paramater used to be called 'synd' FIXME: schedule removal
+ // The parameter used to be called 'synd' FIXME: schedule removal
container = request.getParameter("synd");
if (container == null) {
container = ContainerConfig.DEFAULT_CONTAINER;
diff --git a/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpGadgetContext.java b/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpGadgetContext.java
index 10c4d2c..0e14c2e 100644
--- a/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpGadgetContext.java
+++ b/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpGadgetContext.java
@@ -173,7 +173,7 @@ public class HttpGadgetContext extends GadgetContext {
private static String getContainer(HttpServletRequest req) {
String container = req.getParameter("container");
if (container == null) {
- // The paramater used to be called 'synd' FIXME: schedule removal
+ // The parameter used to be called 'synd' FIXME: schedule removal
container = req.getParameter("synd");
}
return container;
diff --git a/javascript/container/gadgets.js b/javascript/container/gadgets.js
index 7c7b23e..0e6e15d 100644
--- a/javascript/container/gadgets.js
+++ b/javascript/container/gadgets.js
@@ -464,7 +464,7 @@ gadgets.IfrGadget.inherits(gadgets.Gadget);
gadgets.IfrGadget.prototype.GADGET_IFRAME_PREFIX_ = 'remote_iframe_';
-gadgets.IfrGadget.prototype.SYND = 'default';
+gadgets.IfrGadget.prototype.CONTAINER = 'default';
gadgets.IfrGadget.prototype.cssClassGadget = 'gadgets-gadget';
gadgets.IfrGadget.prototype.cssClassTitleBar = 'gadgets-gadget-title-bar';
@@ -530,7 +530,7 @@ gadgets.IfrGadget.prototype.getUserPrefsDialogId = function() {
gadgets.IfrGadget.prototype.getIframeUrl = function() {
return this.serverBase_ + 'ifr?' +
'url=' + encodeURIComponent(this.specUrl) +
- '&container=' + this.SYND +
+ '&container=' + this.CONTAINER +
'&mid=' + this.id +
'&nocache=' + gadgets.container.nocache_ +
'&country=' + gadgets.container.country_ +
diff --git a/php/gadgets/src/ConfiguratorConfig.php b/php/gadgets/src/ContainerConfig.php
similarity index 100%
rename from php/gadgets/src/ConfiguratorConfig.php
rename to php/gadgets/src/ContainerConfig.php
diff --git a/php/gadgets/src/GadgetContext.php b/php/gadgets/src/GadgetContext.php
index 1a3a3ce..806319b 100644
--- a/php/gadgets/src/GadgetContext.php
+++ b/php/gadgets/src/GadgetContext.php
@@ -63,13 +63,12 @@ class GadgetContext {
$container = 'default';
if (!empty($_GET['container'])) {
$container = $_GET['container'];
- // The paramater used to be called 'synd' FIXME: schedule removal
+ // The parameter used to be called 'synd' FIXME: schedule removal
} elseif (!empty($_GET['synd'])) {
$container = $_GET['synd'];
} elseif (!empty($_POST['container'])) {
$container = $_POST['container'];
- // The paramater used to be called 'synd' FIXME: schedule removal
- } elseif (!empty($_POST['synd'])) {
+ // The parameter used to be called 'synd' FIXME: schedule removal
$container = $_POST['synd'];
}
return $container;
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-2.patch, SHINDIG-146-for-humans-squashed-2.patch, SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed-2.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586324#action_12586324 ]
Santiago Gala commented on SHINDIG-146:
---------------------------------------
Chris: my dyslexia :(
I'll rename it properly, thanks for the heads up.
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santiago Gala updated SHINDIG-146:
----------------------------------
Attachment: SHINDIG-146-for-robots-squashed.patch
This one will apply with -p1
It won't apply with --dry-run due to the renames, and it will not svn add the new files or svn rm the deleted ones, though.
Good for automated/collision testing
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santiago Gala updated SHINDIG-146:
----------------------------------
Attachment: SHINDIG-146-for-robots-squashed-3.patch
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP), Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-2.patch, SHINDIG-146-for-humans-3.patch, SHINDIG-146-for-humans-squashed-2.patch, SHINDIG-146-for-humans-squashed-3.patch, SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed-2.patch, SHINDIG-146-for-robots-squashed-3.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santiago Gala updated SHINDIG-146:
----------------------------------
Attachment: SHINDIG-146-for-humans.patch
Patch (series of small incremental commits) for humans.
It will not apply, as subversion does not understand the rename
syntax from git and I'm trying to get feedback rather than it to be applied.
http://github.com/sgala/apache-incubator-shindig/commits/synd-rename/ shows the commits, but they are not that readable, specially renames.
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santiago Gala updated SHINDIG-146:
----------------------------------
Attachment: SHINDIG-146-for-humans-3.patch
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP), Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-2.patch, SHINDIG-146-for-humans-3.patch, SHINDIG-146-for-humans-squashed-2.patch, SHINDIG-146-for-humans-squashed-3.patch, SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed-2.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santiago Gala updated SHINDIG-146:
----------------------------------
Attachment: (was: SHINDIG-146-for-humans.patch)
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586188#action_12586188 ]
Santiago Gala commented on SHINDIG-146:
---------------------------------------
github is just a UI for git repositories, so I don't think it supports it (but you could try to create a RFE in their lighthouse tracker :) )
One thing you can do is to comment either here or on list using their line oriented permalinks, for instance, or inline fragments of either the squashed patch I just attached or the first one.
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585947#action_12585947 ]
Santiago Gala commented on SHINDIG-146:
---------------------------------------
I was giving it a quick try (part of my quest to learn to manage git). Some comments:
The terminology rename produces some confusion in two places:
- there are caja containers, in addition to shindig containers
- the SyndicatorConfig file (ContainerConfig now) says in its javadoc: "Represents per-syndicator configuration for the container". Translating it gives a meaningless definition of the class. I guess "Represents the container configuration" is a better translation.
Is it still something relevant?
ANybody else working on it?
does it make sense to prepare the whole patch and add it here?
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santiago Gala updated SHINDIG-146:
----------------------------------
Attachment: SHINDIG-146-for-humans.patch
Patch (series of small incremental commits) for humans.
It will not apply, as subversion does not understand the rename
syntax from git and I'm trying to get feedback rather than it to be applied.
http://github.com/sgala/apache-incubator-shindig/commits/synd-rename/ shows the commits, but they are not that readable, specially renames.
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591717#action_12591717 ]
Santiago Gala commented on SHINDIG-146:
---------------------------------------
There are only two things that might be missing:
* javascript/container/gadgets.js: this.secureToken = 'john.doe:john.doe:appid:synd:url:0';
I'm not sure if this "synd" is just a string that can be renamed or has a match somewhere, but I think it can be renamed too. Any clue?
* in java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpGadgetContext.java java/gadgets/src/main/java/org/apache/shindig/gadgets/http/GadgetRenderingTask.java and php/gadgets/src/GadgetContext.php it would make sense to deprecate the aliasing of synd to container and schedule some removal date...
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP), Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-2.patch, SHINDIG-146-for-humans-3.patch, SHINDIG-146-for-humans-squashed-2.patch, SHINDIG-146-for-humans-squashed-3.patch, SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed-2.patch, SHINDIG-146-for-robots-squashed-3.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586536#action_12586536 ]
Santiago Gala commented on SHINDIG-146:
---------------------------------------
Actually looking at the difference between both patchs I noticed that I lost one line in a merge, and I have added it in a new commit: http://github.com/sgala/apache-incubator-shindig/commit/90a5708f509d4f12768974a66459d1f101a027b4
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-2.patch, SHINDIG-146-for-humans-squashed-2.patch, SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed-2.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Brown closed SHINDIG-146.
-------------------------------
Resolution: Fixed
This has been applied -- the remaining items are left as deprecated since we'll need to retain them for at least some period of time to give implementations time to transition.
Thanks!
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP), Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-2.patch, SHINDIG-146-for-humans-3.patch, SHINDIG-146-for-humans-squashed-2.patch, SHINDIG-146-for-humans-squashed-3.patch, SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed-2.patch, SHINDIG-146-for-robots-squashed-3.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santiago Gala updated SHINDIG-146:
----------------------------------
Attachment: SHINDIG-146-for-humans-2.patch
readable and split in like 38 separate changes
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-2.patch, SHINDIG-146-for-humans-squashed-2.patch, SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed-2.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588541#action_12588541 ]
Santiago Gala commented on SHINDIG-146:
---------------------------------------
What as we going to do with this patch?
On the minus side, applying it is likely to cause some conflicts to people doing major works, on the plus side, the earlier it gets in the simpled it will be to keep terminology clean.
I think it is basically done after I tweaked a couple of small problems, the last commits in http://github.com/sgala/apache-incubator-shindig/commits/synd-rename-2
Feedback on it?
I can commit myself, specially if a series of "topic" commits renaming one or a few variables at a time is preferred to a big patch.
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-2.patch, SHINDIG-146-for-humans-squashed-2.patch, SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed-2.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589565#action_12589565 ]
Paul Lindner commented on SHINDIG-146:
--------------------------------------
These changes look good.
Can we just get this in now -- such a simple change, yet it seems to have generated so much work!
Thanks Santiago for shepherding this through. What can we do to make this easier in future?
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP), Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-2.patch, SHINDIG-146-for-humans-3.patch, SHINDIG-146-for-humans-squashed-2.patch, SHINDIG-146-for-humans-squashed-3.patch, SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed-2.patch, SHINDIG-146-for-robots-squashed-3.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santiago Gala updated SHINDIG-146:
----------------------------------
Attachment: SHINDIG-146-for-humans-squashed-3.patch
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP), Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-2.patch, SHINDIG-146-for-humans-3.patch, SHINDIG-146-for-humans-squashed-2.patch, SHINDIG-146-for-humans-squashed-3.patch, SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed-2.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586049#action_12586049 ]
Kevin Brown commented on SHINDIG-146:
-------------------------------------
Caja's notion of a container is completely different. Nothing wrong with that, it doesn't really matter to us.
The term "syndicator" is synonymous with "container" from the standpoint of the opensocial and gadget specs, and the preferred terminology is now "container".
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586271#action_12586271 ]
Chris Chabot commented on SHINDIG-146:
--------------------------------------
Looking at the for-robots patch i see:
.../apache/shindig/gadgets/ContainerConfig.java | 306 ++++++++++++++++++++
.../apache/shindig/gadgets/SyndicatorConfig.java | 306 --------------------
php/gadgets/src/ConfiguratorConfig.php | 91 ++++++
php/gadgets/src/SyndicatorConfig.php | 91 ------
In other words, the SyndicatorConfig in java land is renamed to ContainerConfig, however you want to rename the SyndicatorConfig on the php side of things to ConfiguratorConfig? Why not keep the basic file name parity where we can and rename it to ContainerConfig.php?
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589605#action_12589605 ]
Santiago Gala commented on SHINDIG-146:
---------------------------------------
done. It was not as much work as it looks like :) Massaging diffs with --stat & co makes them look much more than they really are :)
I just did it slowly, renaming a few things as I was going and doing "mvn test" from time to time. I was trying git-svn, and local commits are *very* cheap, and they can be amended later. This is the reason why I did so many. Later I restructured them, but this was again just an exercise on the tool, as I wanted to get familiar with git as a tool.
All in all I'm very satistied with it, I did not use eclipse refactoring facilities or similar, just "git grep" and a simple text editor. One thing I *love* is having diffs that "factor out" renames, so I just see the 2-3 lines that change and not 300 lines deleted and 301 added. :)
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP), Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-2.patch, SHINDIG-146-for-humans-3.patch, SHINDIG-146-for-humans-squashed-2.patch, SHINDIG-146-for-humans-squashed-3.patch, SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed-2.patch, SHINDIG-146-for-robots-squashed-3.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591331#action_12591331 ]
Cassie Doll commented on SHINDIG-146:
-------------------------------------
Did your cl completely resolve this issue Santiago, or is there more work to do here?
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP), Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-2.patch, SHINDIG-146-for-humans-3.patch, SHINDIG-146-for-humans-squashed-2.patch, SHINDIG-146-for-humans-squashed-3.patch, SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed-2.patch, SHINDIG-146-for-robots-squashed-3.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586423#action_12586423 ]
Chris Chabot commented on SHINDIG-146:
--------------------------------------
I haven't actually ran the code of the proposed patch yet, but from a conceptual point of view it looks good now as far as the php side goes.
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-2.patch, SHINDIG-146-for-humans-squashed-2.patch, SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed-2.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santiago Gala updated SHINDIG-146:
----------------------------------
Attachment: SHINDIG-146-for-humans-squashed.patch
this patch is again for humans, but it shows all as one big commit, so that all things happen atomically.
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586185#action_12586185 ]
Kevin Brown commented on SHINDIG-146:
-------------------------------------
So far these look pretty good. I haven't looked at every change, but what I have looked at seems correct. Does github support inline comments on patches (something like a real code review tool)?
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santiago Gala updated SHINDIG-146:
----------------------------------
Attachment: SHINDIG-146-for-robots-squashed-2.patch
This one will apply with -p1
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-2.patch, SHINDIG-146-for-humans-squashed-2.patch, SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed-2.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589561#action_12589561 ]
Santiago Gala commented on SHINDIG-146:
---------------------------------------
The patch survived the last refactoring without a single conflict. I attached a new version. As the other times:
- for-humans -> a set of 38 smallish commits doing different things
- for-humans-squashed -> just one diff, but renames are not showed as delete/add
- for robots -> this one will actually apply, one diff with delete/add
I am ready for commit, either as 38 commits or as one jumbo commit.
Regards
Santiago
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features (Javascript), Gadget Rendering Server (Java), Gadget Rendering Server (PHP), Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-2.patch, SHINDIG-146-for-humans-3.patch, SHINDIG-146-for-humans-squashed-2.patch, SHINDIG-146-for-humans-squashed-3.patch, SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed-2.patch, SHINDIG-146-for-robots-squashed-3.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586108#action_12586108 ]
Santiago Gala commented on SHINDIG-146:
---------------------------------------
I am mostly finished with the changes. Now I am trying to separate them into a set of small changes, each one doing an small thing. In this way the succession of commits will be easy to read and review, and any potential conflict with local edits will be easier to handle.
Re terminology, I saw that caja's container are not easily confused anywhere in the code. The "Represents per-syndicator configuration for the container" seems like a bug in the old doc, then.
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-146) Terminology change: Replace
"syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santiago Gala updated SHINDIG-146:
----------------------------------
Attachment: SHINDIG-146-for-humans-squashed-2.patch
Second version, human readable with all changes together
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-squashed-2.patch, SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SHINDIG-146) Terminology change:
Replace "syndicator" with "container" to be in line with current gadgets
terminology.
Posted by "Santiago Gala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586536#action_12586536 ]
sgala edited comment on SHINDIG-146 at 4/14/08 3:18 AM:
----------------------------------------------------------------
Actually looking at the difference between both patchs I noticed that I lost one line in a merge, and I have added it in a new commit, the last commit of:
http://github.com/sgala/apache-incubator-shindig/commits/synd-rename-2
(I had the commit/SHA-1, but those change as I rebase against svn to keep the branches "alive")
was (Author: sgala):
Actually looking at the difference between both patchs I noticed that I lost one line in a merge, and I have added it in a new commit: http://github.com/sgala/apache-incubator-shindig/commit/90a5708f509d4f12768974a66459d1f101a027b4
> Terminology change: Replace "syndicator" with "container" to be in line with current gadgets terminology.
> ---------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-146
> URL: https://issues.apache.org/jira/browse/SHINDIG-146
> Project: Shindig
> Issue Type: Improvement
> Components: Features, Gadgets Server - Java, Gadgets Server - PHP, Sample container & Examples
> Reporter: Kevin Brown
> Attachments: SHINDIG-146-for-humans-2.patch, SHINDIG-146-for-humans-squashed-2.patch, SHINDIG-146-for-humans-squashed.patch, SHINDIG-146-for-humans.patch, SHINDIG-146-for-robots-squashed-2.patch, SHINDIG-146-for-robots-squashed.patch
>
>
> Currently, the term "syndicator" (or "synd") is used throughout the code base to refer to container-specific details. This is mostly a terminology holdover from igoogle, and we should move towards renaming these pieces "container" to be in line with current opensocial / gadgets terminology. Suggested changes:
> - Rename SyndicatorConfig classes to ContainerConfig
> - Rename "syndicator" parameters / variables throughout the code base to "container"
> - Rename "synd" URL parameter to "container" -- possibly maintain "synd" as an alias so that existing deployments don't have to be modified.
> The vast majority of shindig deployments will only ever need to support a single container, so most of these changes won't affect those deployments, but for any deployments that support multiple containers (such as gmodules.com), this change will matter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.