You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by gr...@apache.org on 2021/02/10 03:50:20 UTC

[kudu] 01/03: [test] Fix PasswdWebserverTest.TestCrashInFIPSMode test

This is an automated email from the ASF dual-hosted git repository.

granthenke pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit 49f2a734e773de836ba714dff38a99f41d608788
Author: Grant Henke <gr...@apache.org>
AuthorDate: Mon Feb 8 21:14:51 2021 -0600

    [test] Fix PasswdWebserverTest.TestCrashInFIPSMode test
    
    The order of parameters to the ASSERT_STR_CONTAINS was reversed
    causing the test to fail as seen below. We don’t see this failure in
    standard CI test runs given none of them run in FIPS mode.
    
    Example Failure:
       /data0/somelongdirectorytoavoidrpathissues/src/kudu/src/kudu/server/webserver-test.cc:181: Failure
       Value of: "Digest authentication in FIPS approved mode"
       Expected: has substring "Illegal state: Webserver cannot be started with Digest authentication in FIPS approved mode"
       Actual: "Digest authentication in FIPS approved mode" (of type char [44])
    
    Change-Id: I6bc32cd115bbf1d2b0aa00cc9b9fd80de5433c14
    Reviewed-on: http://gerrit.cloudera.org:8080/17041
    Tested-by: Kudu Jenkins
    Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
    Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
 src/kudu/server/webserver-test.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/kudu/server/webserver-test.cc b/src/kudu/server/webserver-test.cc
index 942bad8..44ffb3f 100644
--- a/src/kudu/server/webserver-test.cc
+++ b/src/kudu/server/webserver-test.cc
@@ -178,7 +178,7 @@ TEST_F(PasswdWebserverTest, TestCrashInFIPSMode) {
 
   Status s = server_->Start();
   ASSERT_TRUE(s.IsIllegalState());
-  ASSERT_STR_CONTAINS("Digest authentication in FIPS approved mode", s.ToString());
+  ASSERT_STR_CONTAINS(s.ToString(), "Digest authentication in FIPS approved mode");
 }
 
 class SpnegoWebserverTest : public WebserverTest {